Scott Green

Thanks Anthony. I believe this is what @cantcodeatall describes here: https://github.com/BittyTax/BittyTax/issues/22#issuecomment-1988115299 > The position size is shown at every line. If it goes to zero, the position is closed (or...

Hi @AnthonyFJGarner, this should be fixed now, see https://github.com/BittyTax/BittyTax/commit/23fb36af8f37931df22d97575ba85e8032d2b2d7. @cantcodeatall provided a sample for this using https://test.deribit.com, which lets you test strategies with no real money. It did not require...

Thanks @AnthonyFJGarner, really appreciate your invaluable knowledge. Happy to correct if this solution is not working as expected.

Hi @AnthonyFJGarner, please see https://github.com/BittyTax/BittyTax/commit/9452de0102b9436232f112bcbb3170fd1374f5f9, and follow-up change https://github.com/BittyTax/BittyTax/commit/ae89179747134b1d9cdb6d6ef8bcb85b090debf4. The parser is now using a "close buy" or "close sell" trade as the trigger to calculate the P&L. For a...

Closing this issue. Please open a new one if there are still problems.

This will remove the funding fee when it's negative and add it when it's positive. If you run the conv tool with (-d) you can see the unrealised_pnl is correct...

Thanks for feedback will investigate this and get back to you.

@AnthonyFJGarner, I've just pushed a fix for the double funding fees, see https://github.com/BittyTax/BittyTax/commit/909a84be8ce4b3a36655b4c217d9fb36ba3c7f3d. Please re-test. > How is Margin-Fee calculated? It does not seem to be funding fee, at least...

The reason for keeping the fees separate is because, how margin fees are reported will be different depending on if it's income or capital gains. So this gives the user...

Hi @AnthonyFJGarner, thanks for this. I will change the parser so the funding fee is included with the unrealised_pnl to prevent any issues where the funding fee is net positive.