nng icon indicating copy to clipboard operation
nng copied to clipboard

Add MQTT support for NNG

Open JaylinYu opened this issue 3 years ago • 9 comments

Hereby we presenting a huge pull request to make NNG an MQTT SDK, which I think is a big step for NNG.

As we discussed before, I limited the commit number to 6 plus 3 from upstream/mqtt branch. And we also manage to reorganize the code base to fit with NNG style.

And I know there are some places we are agreed to improve, such as the QoS mechanism in the transport layer, and the way to do connect_cb of MQTT. But I believe it is more efficient to proceed this within a Github pr.

JaylinYu avatar Jan 12 '22 10:01 JaylinYu

This pull request introduces 8 alerts when merging 11a2c50c63e2a3b65c2fc78857759ce0250a7f77 into 5e06e98541ff223e7a18b6a61120532acd09d410 - view on LGTM.com

new alerts:

  • 8 for FIXME comment

lgtm-com[bot] avatar Jan 12 '22 10:01 lgtm-com[bot]

This pull request introduces 10 alerts when merging 9f14d41b72b56aafac137ced3f76d6e6ec1ad5f1 into 5e06e98541ff223e7a18b6a61120532acd09d410 - view on LGTM.com

new alerts:

  • 10 for FIXME comment

lgtm-com[bot] avatar Jan 13 '22 03:01 lgtm-com[bot]

This pull request introduces 10 alerts when merging ccef0709d94f4e05bb1bf42fa81298f1539db1f1 into 5e06e98541ff223e7a18b6a61120532acd09d410 - view on LGTM.com

new alerts:

  • 10 for FIXME comment

lgtm-com[bot] avatar Jan 19 '22 04:01 lgtm-com[bot]

This pull request introduces 10 alerts when merging 2f47cf7b7a9966f09c55bb8f1011da54320cecb9 into 5e06e98541ff223e7a18b6a61120532acd09d410 - view on LGTM.com

new alerts:

  • 10 for FIXME comment

lgtm-com[bot] avatar Jan 19 '22 06:01 lgtm-com[bot]

This pull request introduces 3 alerts when merging 3f97152e9dd4809f17ecaf6d0b72891e1680d421 into 5e06e98541ff223e7a18b6a61120532acd09d410 - view on LGTM.com

new alerts:

  • 3 for FIXME comment

lgtm-com[bot] avatar Jan 21 '22 04:01 lgtm-com[bot]

roger that. Glad you start looking at our PR. the start is the beginning of the end.

JaylinYu avatar Jan 25 '22 10:01 JaylinYu

This pull request introduces 1 alert when merging 08b91738295490988dda1dc6af7f4fbeaa8cec39 into bcf4f0965b0c6d8a6ad124b6672a32b56855f2a2 - view on LGTM.com

new alerts:

  • 1 for FIXME comment

lgtm-com[bot] avatar Feb 03 '22 06:02 lgtm-com[bot]

This pull request introduces 1 alert when merging 8880fd7b820b88b1832b86136d419f14eddfbf4e into bcf4f0965b0c6d8a6ad124b6672a32b56855f2a2 - view on LGTM.com

new alerts:

  • 1 for FIXME comment

lgtm-com[bot] avatar Feb 04 '22 09:02 lgtm-com[bot]

Dear @JaylinYu or @gdamore May I ask nicely: Is there any news if it is possibly in planning that this request will be completed? Thanks for your service. Kindest regards, Roland Bruggmann aka @brugr9

brugr9 avatar Oct 10 '22 14:10 brugr9

new one is coming

JaylinYu avatar May 05 '24 00:05 JaylinYu