mangos icon indicating copy to clipboard operation
mangos copied to clipboard

fixes #198 negative send/receive deadlines do not work

Open gdamore opened this issue 4 years ago • 1 comments

This actually affected pretty much all the protocols and both send and receive deadlines. While here we've also made sure that a non-blocking check will not fail if a message can immediately be sent or received.

gdamore avatar Sep 27 '20 23:09 gdamore

Codecov Report

Merging #216 into master will decrease coverage by 0.38%. The diff coverage is 98.30%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master     #216      +/-   ##
===========================================
- Coverage   100.00%   99.61%   -0.39%     
===========================================
  Files           46       43       -3     
  Lines         6584     4978    -1606     
===========================================
- Hits          6584     4959    -1625     
- Misses           0       15      +15     
- Partials         0        4       +4     
Flag Coverage Δ
#unittests 99.61% <98.30%> (-0.39%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
protocol/xbus/xbus.go 98.78% <85.71%> (-1.22%) :arrow_down:
protocol/xreq/xreq.go 98.05% <91.66%> (-1.95%) :arrow_down:
protocol/rep/rep.go 100.00% <100.00%> (ø)
protocol/req/req.go 100.00% <100.00%> (ø)
protocol/respondent/respondent.go 98.89% <100.00%> (-1.11%) :arrow_down:
protocol/sub/sub.go 99.47% <100.00%> (-0.53%) :arrow_down:
protocol/surveyor/surveyor.go 99.15% <100.00%> (-0.85%) :arrow_down:
protocol/xpair/xpair.go 100.00% <100.00%> (ø)
protocol/xpull/xpull.go 100.00% <100.00%> (ø)
protocol/xpush/xpush.go 100.00% <100.00%> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e0b0da2...4d69051. Read the comment docs.

codecov[bot] avatar Sep 27 '20 23:09 codecov[bot]