nf-interpreter icon indicating copy to clipboard operation
nf-interpreter copied to clipboard

Published 20 hours ago • verified publisher icon nanoframework

Add more FLASH alignment

Open snikeguo opened this issue 2 years ago • 11 comments

Description

Motivation and Context

  • Fixes/Closes/Resolves nanoFramework/Home#NNNN

How Has This Been Tested?

Screenshots

Types of changes

  • [x] Improvement (non-breaking change that improves a feature, code or algorithm)
  • [ ] Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • [ ] New feature (non-breaking change which adds functionality to code)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Config and build (change in the configuration and build system, has no impact on code or features)
  • [ ] Dev Containers (changes related with Dev Containers, has no impact on code or features)
  • [ ] Dependencies (update dependencies and changes associated, has no impact on code or features)
  • [ ] Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • [x] My code follows the code style of this project (only if there are changes in source code).
  • [x] My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • [x] I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • [x] I have read the CONTRIBUTING document.
  • [x] I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

snikeguo avatar Aug 12 '22 08:08 snikeguo

Hi @snikeguo,

:disappointed: If this PR does address any issue, you have to remove the content Fixes/Closes/Resolves(...) under 'Motivation and Context'.

nfbot avatar Aug 12 '22 08:08 nfbot

Hi @snikeguo,

:disappointed: If this PR does address any issue, you have to remove the content Fixes/Closes/Resolves(...) under 'Motivation and Context'.

nfbot avatar Aug 12 '22 08:08 nfbot

Hi @snikeguo,

:disappointed: If this PR does address any issue, you have to remove the content Fixes/Closes/Resolves(...) under 'Motivation and Context'.

nfbot avatar Aug 12 '22 08:08 nfbot

Hi @snikeguo,

:disappointed: If this PR does address any issue, you have to remove the content Fixes/Closes/Resolves(...) under 'Motivation and Context'.

nfbot avatar Aug 12 '22 08:08 nfbot

Hi @snikeguo,

:disappointed: If this PR does address any issue, you have to remove the content Fixes/Closes/Resolves(...) under 'Motivation and Context'.

nfbot avatar Aug 12 '22 08:08 nfbot

Hi @snikeguo,

:disappointed: If this PR does address any issue, you have to remove the content Fixes/Closes/Resolves(...) under 'Motivation and Context'.

nfbot avatar Aug 12 '22 08:08 nfbot

Hi @snikeguo,

:disappointed: If this PR does address any issue, you have to remove the content Fixes/Closes/Resolves(...) under 'Motivation and Context'.

nfbot avatar Aug 12 '22 08:08 nfbot

@snikeguo there are issues with the code style on the source files. A PR was submitted with the code style fixes. Please click https://github.com/snikeguo/nf-interpreter/pull/2, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

nfbot avatar Aug 12 '22 08:08 nfbot

@snikeguo there are issues with the code style on the source files. A PR was submitted with the code style fixes. Please click https://github.com/snikeguo/nf-interpreter/pull/1, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

nfbot avatar Aug 12 '22 08:08 nfbot

@snikeguo can you please address the review comments so this can be moved forward?

josesimoes avatar Sep 22 '22 07:09 josesimoes

@snikeguo can you please address the review comments so this can be moved forward?

I will solve it before 2022.10.1

snikeguo avatar Sep 22 '22 07:09 snikeguo

@snikeguo there are issues with the code style on the source files. A PR was submitted with the code style fixes. Please click https://github.com/snikeguo/nf-interpreter/pull/3, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

nfbot avatar Nov 18 '22 01:11 nfbot

@snikeguo there are issues with the code style on the source files. A PR was submitted with the code style fixes. Please click https://github.com/snikeguo/nf-interpreter/pull/4, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

nfbot avatar Nov 18 '22 01:11 nfbot

Closing as there have been no more developments on this matter and also more flash alignments have been recently added.

josesimoes avatar Jan 16 '23 18:01 josesimoes