nanoFramework.M5Stack icon indicating copy to clipboard operation
nanoFramework.M5Stack copied to clipboard

add M5 CoreInk project

Open xas opened this issue 1 year ago • 5 comments

Description

  • add CoreInk project for the CoreInk product

Motivation and Context

  • add ready-to-go properties for the CoreInk product

How Has This Been Tested?

see README file for implemented properties and testing result

Types of changes

  • [ ] Improvement (non-breaking change that improves a feature, code or algorithm)
  • [ ] Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • [x] New feature (non-breaking change which adds functionality to code)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [x] Config and build (change in the configuration and build system, has no impact on code or features)
  • [ ] Dependencies (update dependencies and changes associated, has no impact on code or features)
  • [ ] Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • [ ] Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • [x] My code follows the code style of this project (only if there are changes in source code).
  • [ ] My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • [ ] I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • [ ] I have added new tests to cover my changes.

Summary by CodeRabbit

  • New Features

    • Introduced support for the nanoFramework.CoreInk package in the pipeline.
    • Added a comprehensive packages.lock.json file for nanoFramework.CoreInk, detailing essential project dependencies.
  • Bug Fixes

    • Ensured integrity verification through content hashes in the new dependencies manifest.

xas avatar Oct 27 '23 07:10 xas

Draft mode as missing for:

  • [ ] nuGet generation implementation
  • [ ] PR validation for screen implementation
  • [ ] screen implementation

xas avatar Oct 27 '23 07:10 xas

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
15.1% 15.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

sonarqubecloud[bot] avatar Oct 27 '23 08:10 sonarqubecloud[bot]

@xas any update on this?

networkfusion avatar Jun 14 '24 14:06 networkfusion

@networkfusion Yeah sorry, I was waiting for the merge of the E-Ink driver and then lot of work happened 😞

I will try to update the PR this week

xas avatar Jun 24 '24 07:06 xas

Walkthrough

The pull request introduces a new NuGet package, nanoFramework.CoreInk, by modifying the azure-pipelines.yml file to include a template invocation for packaging. Additionally, a packages.lock.json file is created for nanoFramework.CoreInk, detailing its dependencies, which include various libraries necessary for functionality. This update expands the capabilities of the project without altering existing functionality.

Changes

File Change Summary
azure-pipelines.yml Added a new template invocation for nanoFramework.CoreInk package using the existing packaging template.
nanoFramework.CoreInk/packages.lock.json Created a new packages.lock.json file listing dependencies including nanoFramework.CoreLibrary, nanoFramework.Graphics.Core, and several device-specific libraries.

Possibly related PRs

  • #334: Updates the nanoFramework.Graphics.Core package, which is a dependency for the new nanoFramework.CoreInk package.
  • #338: Updates the nanoFramework.Iot.Device.Ws28xx.Esp32 package, relevant to the ecosystem of packages managed in the main PR.
  • #344: Updates several dependencies, including UnitsNet.nanoFramework.Temperature, which is also mentioned in the main PR's context of package management.

Suggested labels

CI: Publish Release, Type: dependencies


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- I pushed a fix in commit <commit_id>, please review it. -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples: -- @coderabbitai generate unit testing code for this file. -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase. -- @coderabbitai read src/utils.ts and generate unit testing code. -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format. -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jul 10 '24 13:07 coderabbitai[bot]