Nanodicom icon indicating copy to clipboard operation
Nanodicom copied to clipboard

Rename parameters to fix nanodicom under php7

Open jacobalberty opened this issue 9 years ago • 3 comments

Without this patch running nanodicom under php7 throws a "Redefinition of parameter" compile time error.

jacobalberty avatar Dec 17 '15 16:12 jacobalberty

Same problem in using php 7.1.

yeoupooh avatar Aug 20 '18 06:08 yeoupooh

core.php:1082 has $arg2 defined twice in _dummy(). It just needs a slight update to remove the second:

from 1082: protected function _dummy($arg1 = NULL, $arg2 = NULL, $arg2 = NULL, ... ______________________________________________[keep]________^remove_this^

1082: protected function _dummy($arg1 = NULL, $arg2 = NULL, $arg3 = NULL, ...

D4V3M0NK avatar Dec 16 '19 21:12 D4V3M0NK

the PR(https://github.com/nanodocumet/Nanodicom/pull/20) fix it?

uiosun avatar Jul 06 '21 07:07 uiosun