nano-node icon indicating copy to clipboard operation
nano-node copied to clipboard

Improved polymorphism in rep_crawler::cleanup_reps()

Open brandon-bb opened this issue 1 year ago • 1 comments

Addresses #3946

This solution is an implementation of the proposed one by @simpago - channel state is represented using a boolean variable. tcp_channels::purge() toggles this variable to close the channel. As this was crafted to introduce minimal changes, there could be a better way to represent channel state.

brandon-bb avatar Jan 16 '24 17:01 brandon-bb

I had a quick look at the test results. It doesn't seem to pass the unit tests yet. Also when spinning up a local nano network with this version, most of the blocks don't confirm.

Taken from https://ct.bnano.info : Screenshot 2024-01-16 at 23 13 55

gr0vity-dev avatar Jan 16 '24 22:01 gr0vity-dev

Not relevant anymore after the rep_crawler overhaul and recent networking improvements.

dsiganos avatar Apr 30 '24 14:04 dsiganos