nano-node icon indicating copy to clipboard operation
nano-node copied to clipboard

Published 20 hours ago • verified publisher icon nanocurrency

Remove UDP support from the network tests

Open thsfs opened this issue 2 years ago • 1 comments

Migrates or remove network tests that use UDP.

  • Adds a helper function to add a system node disconnected from its network.
  • Organized the client/server of the tcp_connection test to be in distinct classes.
  • Removed tests that are exclusive to UDP, otherwise migrated them to TCP or inproc.

Fixes issue: https://github.com/nanocurrency/nano-node/issues/3846

thsfs avatar Aug 25 '22 17:08 thsfs

Thiago, it appears that most objections are about the rmoeval of tests. So let's reinstate them as they were (using UDP) and get traction on this Pr, which on the whole is good and almost ready to merge.

dsiganos avatar Aug 26 '22 14:08 dsiganos