NovelDokusha icon indicating copy to clipboard operation
NovelDokusha copied to clipboard

Please add feature for reading [include and display images from online sources into the reader]

Open excalibur1010 opened this issue 2 years ago • 22 comments

Please Add feature reading mode html Some novel including embed image

Btw i love your app Thx for made this app You are amazing

excalibur1010 avatar Jun 28 '22 18:06 excalibur1010

Hey @excalibur1010 do you have any example, link of some novel that has embedded images? That would be the the best way to help implement this feature.

nanihadesuka avatar Jun 29 '22 17:06 nanihadesuka

Hey @excalibur1010 do you have any example, link of some novel that has embedded images? That would be the the best way to help implement this feature.

Main

https://www.novelupdates.com/series/kurasu-no-daikiraina-joshi-to-kekkon-suru-koto-ni-natta/

Chapter

https://www.novelupdates.com/extnu/6292172/ https://www.novelupdates.com/extnu/6295175/

excalibur1010 avatar Jun 29 '22 17:06 excalibur1010

Added with 4d95b55ee699eb0629bcbf7ec4f20abd70d0c4f9 Note that still needs some work so that the images are stored fully offline and for taken into account for backup, but aside from that it now works.

The apk installer will be available for the next release (next release time is undefined) but you can still build the app yourself if you want it now.

nanihadesuka avatar Jul 02 '22 15:07 nanihadesuka

Here is apk with that build. apk

Technically we can add manga source now.

Nabeelshar avatar Jul 02 '22 16:07 Nabeelshar

Here is apk with that build. apk

Technically we can add manga source now.

Screenshot_2022-07-02-23-42-33-800_com.google.android.packageinstaller.jpg

Can't install

excalibur1010 avatar Jul 02 '22 16:07 excalibur1010

Here is apk with that build. apk Technically we can add manga source now.

Screenshot_2022-07-02-23-42-33-800_com.google.android.packageinstaller.jpg

Can't install

Properly need to delete previous version as I didn't update the version

Nabeelshar avatar Jul 02 '22 16:07 Nabeelshar

Here is apk with that build. apk Technically we can add manga source now.

Screenshot_2022-07-02-23-42-33-800_com.google.android.packageinstaller.jpg

Can't install

Properly need to delete previous version as I didn't update the version

Screenshot_2022-07-02-23-48-38-364_com.android.vending.jpg

Still can't install and blocked by play protect

excalibur1010 avatar Jul 02 '22 16:07 excalibur1010

Skip it it say that when the app is in debug mode or is not on playstore. TO check if there is any virus you can test here virustotal by google

Nabeelshar avatar Jul 02 '22 16:07 Nabeelshar

Please don't share debug builds, only release ones or at least with optimizations enabled.

nanihadesuka avatar Jul 02 '22 20:07 nanihadesuka

There is optimization?!

Nabeelshar avatar Jul 03 '22 07:07 Nabeelshar

@excalibur1010 last release with this feature added: https://github.com/nanihadesuka/NovelDokusha/releases/tag/v1.7.0

nanihadesuka avatar Jul 16 '22 18:07 nanihadesuka

Screenshot_2022-07-17-02-05-49-498_my noveldokusha

Image still not show @nanihadesuka

excalibur1010 avatar Jul 16 '22 19:07 excalibur1010

@excalibur1010 what chapter is it

nanihadesuka avatar Jul 16 '22 19:07 nanihadesuka

Screenshot_2022-07-17-12-47-43-862_my noveldokusha

All chapters From this novel Kurasu no Daikiraina Joshi to Kekkon Suru Koto ni Natta @nanihadesuka

excalibur1010 avatar Jul 17 '22 05:07 excalibur1010

@excalibur1010 are you sure you are on the last version (1.7.0) of the app? I tried several times and all works fine. You could try to redownload the chapters.

nanihadesuka avatar Jul 17 '22 10:07 nanihadesuka

Screenshot_2022-07-18-09-31-03-311_com miui securitycenter Screenshot_2022-07-18-09-32-11-816_my noveldokusha

Already try redownload Still same

excalibur1010 avatar Jul 18 '22 02:07 excalibur1010

IMG_20220718_142248.jpg

It's showing this.

Nabeelshar avatar Jul 18 '22 09:07 Nabeelshar

IMG_20220718_142248.jpg

It's showing this.

Screenshot_2022-07-19-17-20-43-356_my noveldokusha

My mine it's not like that

excalibur1010 avatar Jul 19 '22 10:07 excalibur1010

Unable to reproduce, will leave it as it is for now.

nanihadesuka avatar Jul 25 '22 18:07 nanihadesuka

@excalibur1010 still unable to see images? If fixed, close this issue please.

nanihadesuka avatar Aug 13 '22 13:08 nanihadesuka

Closed, will be considered fixed unless more complains are received

nanihadesuka avatar Aug 15 '22 02:08 nanihadesuka

I'm having the same issue: instead of image html tag is displayed. I tried it with cheaper OP provided and local EPUB

App version: 2.0.1

wasu-code avatar Nov 26 '23 16:11 wasu-code

Unfortunately I can't seem to reproduce the issue, will keep open :/

nanihadesuka avatar Jun 24 '24 19:06 nanihadesuka

Issue still happening?

nanihadesuka avatar Jul 10 '24 19:07 nanihadesuka

Very old issue. (I) haven't been able to reproduce the bug in the new version. I will close for now and assume is fixed.

nanihadesuka avatar Jul 29 '24 21:07 nanihadesuka