hubot-irc icon indicating copy to clipboard operation
hubot-irc copied to clipboard

Private message listener should call createUser

Open briangreenery opened this issue 10 years ago • 3 comments

It looks like the pm listener should probably be calling createUser so that the user id is set.

briangreenery avatar Mar 17 '14 10:03 briangreenery

Without this any scripts that use the user id fail when used over pm.

Boggart avatar Apr 10 '14 21:04 Boggart

Seems like a pretty straight forward change. If either of you have time to put something together I'd be able to merge and publish it pretty quickly.

jgable avatar Apr 11 '14 14:04 jgable

I've got it changed on my fork but when I update my hubot on heroku it seems to just use the old version even though I changed package.json to point to github, so I can't test right now. If I manage to get hubot/heroku to pull my repo and it works I'll submit a pull request.

https://github.com/Boggart/hubot-irc

~~EDIT: I still haven't got heroku to use my fork, it's set to and just doesn't. If anyone else can test my fork to see if it fixes, I'd greatly appreciate it, if not I do plan to move my hubot to either openshift or my own server. When I do, I'll see if I can't get it to use my version.~~

Edit 2: I'm unable to do anything with this at this time, I'm doing this edit because it seems crappy to have disappeared after talking about fixing it. (Channel died, some auto-update broke the bot and I don't have the time.)

Boggart avatar Apr 11 '14 18:04 Boggart