nancy collins

"it can be made to work"? it is already working. maybe a bug fix is needed for code that is now being called that wasn't tested before, but it's not...

would you be able to close your existing pull request and open another one with just the proposed changes to the model_mod.f90 in it, relative to the main branch? the...

great - i now see only a single changed file. thank you!! i can review that. but i still don't see a global variable around line 260 in the proposed...

kevin - maybe you talked about this in the standup - if so, my apologies. i'm getting 'issues' and 'pull requests' confused. if you want to deal with other changes...

thanks. where i got confused was how no_assim_above_pressure related to missing that normalization flag which only applies to scale height. it's needed for initializing no_assim_above_scaleh, not pressure. it does look...

kevin - i'm going to post my code review in just a bit. i hope it doesn't come across as harsh - it's hard for me to be clear but...

starting a new issue is probably better but we can do it either way. here is the calling sequence in filter: model_interpolate() is called during forward operator computation, for all...

i have a suggestion to ease kevin's mind about how DA treats scale height. we have a model_nml namelist item to control how scale height is computed called "no_normalization_of_scale_heights". i...

kevin, this looks good with just a few comment about the implication sections. 1) if the code uses p_reference which is constant instead of p_surface (which varies by location), then...

1) sorry helen! my point was, i think, that if you use a constant reference pressure that you will get identical distance results to simple log(p) because everything else in...