godown icon indicating copy to clipboard operation
godown copied to clipboard

lpush, rpush api inconsistent.

Open namreg opened this issue 5 years ago • 5 comments

I found lpush, rpush api inconsistent.

// RPush appends a new value(s) to the list stored at the given key.
func (c *Client) RPush(key, value string, values ...string) StatusResult
//LPush prepends a new value to the list stored at the given key.
func (c *Client) LPush(key, value string) StatusResult

I think setting the api this way will make it more comfortable to use.

func (c *Client) RPush(key, values ...string) StatusResult

Originally posted by @fangpianqi in https://github.com/namreg/godown/issues/5#issuecomment-443554022

namreg avatar Dec 03 '18 09:12 namreg

Please see this issue. I found a big problem when using the godown client.

https://github.com/namreg/godown/issues/7

fangpianqi avatar Dec 03 '18 09:12 fangpianqi

@fangpianqi I've seen it. I will investigate asap and let you know. Thank you!

namreg avatar Dec 03 '18 09:12 namreg

I want to join the godown team. I have only recently used the Go language. I can only help with field testing. I am ready to take the time to start reading the code. please give me some advices. :)

Currently, my team uses godown in production environments, partially replacing redis.

fangpianqi avatar Dec 03 '18 09:12 fangpianqi

@fangpianqi I have added you as a collaborator, welcome to the godown team !:) Nevertheless, it would be great, if any changes in the repository you will make via sending a pull request. Thanks!

namreg avatar Dec 03 '18 10:12 namreg

@fangpianqi I have added you as a collaborator, welcome to the godown team !:) Nevertheless, it would be great, if any changes in the repository you will make via sending a pull request. Thanks!

That's great. I'll be careful.

fangpianqi avatar Dec 03 '18 10:12 fangpianqi