nmcontrol icon indicating copy to clipboard operation
nmcontrol copied to clipboard

Fix various warnings/errors detected by PyLint

Open JeremyRand opened this issue 10 years ago • 4 comments

One of the fixes was in platform-dependent code, someone please test to make sure it still boots without exceptions on Windows.

JeremyRand avatar May 12 '15 07:05 JeremyRand

Why do you suggest to convert all the option dicts to lists?

phelixbtc avatar May 28 '15 16:05 phelixbtc

@phelixbtc Khal's code was converting dicts to lists at run time (but also accepted lists verbatim); that makes it impossible for PyLint to do static analysis of that code to check for errors.

JeremyRand avatar May 28 '15 22:05 JeremyRand

FTFY: https://github.com/namecoin/nmcontrol/pull/83

phelixbtc avatar Jun 03 '15 18:06 phelixbtc

Now that #83 is merged, I'll rebase this soon to not include that particular fix.

JeremyRand avatar Aug 07 '15 02:08 JeremyRand