ncdns icon indicating copy to clipboard operation
ncdns copied to clipboard

GOROOT problem on Windows

Open negatratoron opened this issue 7 years ago • 3 comments

Here's the output I get when I run the build commands on Windows:

C:\Users\rofl\go>go get -d -t -u github.com/namecoin/ncdns/...

C:\Users\rofl\go>go generate github.com/namecoin/ncdns/...
install.sh: line 6: no match: C:\Go/src/crypto/x509/*
src\github.com\namecoin\ncdns\x509\x509_splice.go:9: running "bash": exit status 1

I guess backslashes in GOROOT need to be escaped.

Setting the GOROOT environment variable does not matter; I get the same error.

However, when I edit install.sh and change line 6 from cp -a $(go env GOROOT)/src/crypto/x509/* ./ to cp -a C:/Go/src/crypto/x509/* ./, the command succeeds.

EDIT: Oh, goroot, goroot!

negatratoron avatar Nov 27 '17 07:11 negatratoron

Which version of Windows? I don't think we've tested building on Windows, since Windows doesn't have Bash usually.

JeremyRand avatar Nov 27 '17 20:11 JeremyRand

Windows 7 in a Cygwin shell.

negatratoron avatar Nov 27 '17 22:11 negatratoron

Honestly I'm inclined to not support building on Windows, since it sounds like this would add complexity (thereby harming auditability), and cross-compiling from GNU/Linux is a lot more resistant to compromised build machines. If anyone wants to contribute a PR that fixes this without adding complexity, I'd be happy to review it though.

JeremyRand avatar Mar 24 '18 02:03 JeremyRand