ncdns icon indicating copy to clipboard operation
ncdns copied to clipboard

Makefile doesn't invoke `go generate`

Open negatratoron opened this issue 7 years ago • 4 comments

I'm getting the following errors trying to build ncdns (version 09a88dc) using Option B:

lol@foldingmachine:~/p/ncdns$ make
    [RELOCATE]
    [GO-GET]      github.com/namecoin/ncdns
# github.com/namecoin/ncdns/x509
../gopath/src/github.com/namecoin/ncdns/x509/x509_splice.go:37: undefined: Certificate
../gopath/src/github.com/namecoin/ncdns/x509/x509_splice.go:50: undefined: signingParamsForPublicKey
../gopath/src/github.com/namecoin/ncdns/x509/x509_splice.go:58: undefined: marshalPublicKey
../gopath/src/github.com/namecoin/ncdns/x509/x509_splice.go:67: undefined: buildExtensions
../gopath/src/github.com/namecoin/ncdns/x509/x509_splice.go:72: undefined: subjectBytes
../gopath/src/github.com/namecoin/ncdns/x509/x509_splice.go:77: undefined: subjectBytes
../gopath/src/github.com/namecoin/ncdns/x509/x509_splice.go:83: undefined: tbsCertificate
../gopath/src/github.com/namecoin/ncdns/x509/x509_splice.go:114: undefined: certificate
Makefile:77: recipe for target '.gotten' failed
make: *** [.gotten] Error 2

Not sure what the problem is. I get the same error on v0.0.5 and v0.0.4.

negatratoron avatar Nov 18 '17 03:11 negatratoron

It works if I go with Option A.

negatratoron avatar Nov 18 '17 07:11 negatratoron

This fails for me on ubuntu xenial using Option A, in this manner. I'm using go version go1.6.2 linux/amd64. How to rectify this error???

raininja avatar Dec 05 '17 20:12 raininja

A was failing because I didn't have mercurial installed. it might be nice to flesh out the error messages or check for prereqs before the script starts it's main function?? #58

raininja avatar Dec 06 '17 01:12 raininja

This seems to be because the Makefile doesn't invoke go generate, so the x509 fork doesn't build properly. Admittedly I'm a bit hesitant to expend much effort on the Makefile, since the build scripts are going to be changing drastically in the foreseeable future when we switch to RBM.

JeremyRand avatar Mar 24 '18 02:03 JeremyRand