namecoin-core icon indicating copy to clipboard operation
namecoin-core copied to clipboard

Tag nc22.0

Open JeremyRand opened this issue 3 years ago • 3 comments

I've just pushed a 22.0-draft branch. This branch is identical to nc0.22.0 except 3 backported bugfixes from the 22.x branch have been cherry-picked. @domob1812 Can you take a look at the 22.0-draft branch and check that it looks okay? If it passes your review, can you rename that branch to 22.0 (i.e. remove the -draft suffix) and tag it as nc22.0 (no leading 0. in the version number)?

JeremyRand avatar Feb 04 '22 13:02 JeremyRand

Out of curiosity, what are the backports and why can't we use the 22.x branch as basis?

domob1812 avatar Feb 07 '22 09:02 domob1812

They're the same bugfixes that we already backported to 22.x from master. I'm hesitant to tag from 22.x directly since that contains upstream Bitcoin commits that aren't part of a Bitcoin tag, which means they've gotten less QA testing and makes it harder for Namecoin users to reason about what Bitcoin commits they're getting from our tag.

JeremyRand avatar Feb 08 '22 01:02 JeremyRand

Makes sense, all done.

domob1812 avatar Feb 08 '22 08:02 domob1812