namecoin-core icon indicating copy to clipboard operation
namecoin-core copied to clipboard

(WIP) Explicitly use hex encoding in GUI to RPC API

Open JeremyRand opened this issue 3 years ago • 6 comments

Prevents corruption issues that were happening when default encoding wasn't ASCII. Also a prereq to supporting binary data in the GUI.

JeremyRand avatar Dec 30 '21 02:12 JeremyRand

@domob1812 This PR is ready for review.

JeremyRand avatar Dec 30 '21 03:12 JeremyRand

@domob1812 Addressed review, and fixed merge conflict via rebase. Feel free to proceed with review; I'll squash before you merge.

JeremyRand avatar Mar 25 '22 01:03 JeremyRand

@domob1812 Review addressed; let me know if this is ready for a squash.

JeremyRand avatar Jun 13 '22 15:06 JeremyRand

@domob1812 Review addressed once again; let me know if this is ready for a squash.

JeremyRand avatar Jan 05 '23 13:01 JeremyRand

Rebased to fix merge conflict. I still need to confirm that the rebase didn't break anything, will test that in the next day or two.

JeremyRand avatar Mar 20 '24 03:03 JeremyRand

Blocked by https://github.com/namecoin/namecoin-core/pull/536

JeremyRand avatar Mar 24 '24 11:03 JeremyRand

Blocked by #536

#536 is merged. @domob1812 this is ready for review.

JeremyRand avatar Oct 15 '24 16:10 JeremyRand

All looks good, thanks! ACK 922da75795fed146462184468447d8bc2167f19d.

domob1812 avatar Oct 15 '24 17:10 domob1812