node-vault-client icon indicating copy to clipboard operation
node-vault-client copied to clipboard

Published 20 hours ago • verified publisher icon namecheap

Return Instance if instance already booted when calling vault.boot() function.

Open ansukumari opened this issue 10 months ago • 1 comments

The description of the boot function says that "Calling Vault.boot multiple times with the same name will return the same instance." but in the code it is throwing error when the instance is already booted. Changed the code and its respective test to return the instance instead of throwing error.

ansukumari avatar Apr 29 '24 13:04 ansukumari

@blackrabbit99 can you please review this.

ansukumari avatar May 06 '24 09:05 ansukumari

@vzholudev @b1ff , might be you can revire this?

malderete avatar Jun 07 '24 10:06 malderete

Hey @malderete thanks for a ping, will look into this shortly.

b1ff avatar Jun 07 '24 10:06 b1ff

Merged, thanks for a contribution, will publish a new version shortly to NPM

b1ff avatar Jun 07 '24 11:06 b1ff

v1.0.1 is available in NPM

b1ff avatar Jun 07 '24 11:06 b1ff

@b1ff awesome news, thanks for the quick response! 😄

malderete avatar Jun 07 '24 11:06 malderete