OpenHashTab icon indicating copy to clipboard operation
OpenHashTab copied to clipboard

Update the binary on Winget

Open rehanhooda opened this issue 3 years ago • 4 comments

Hi dev,

Could you update the OpenHashTab file on the winget repo? Currently, it is showing 2.3.0 version there.

image

Thanks,

rehanhooda avatar Jun 29 '21 03:06 rehanhooda

Yeah, I've also noticed that the pull request here https://github.com/microsoft/winget-pkgs/pull/7037 has already been merged since February, but it's still not showing with the winget-cli. But I also have no Idea, how the process behind it works, so ¯_(ツ)_/¯

MisterX2000 avatar Jul 17 '21 15:07 MisterX2000

to be honest.. me neither, i just copied what the pr before me did

namazso avatar Jul 17 '21 19:07 namazso

In addition to the previous update PR, I saw this one https://github.com/microsoft/winget-pkgs/pull/21601 Which targets v3.0.1 but I'm still seeing

> winget search openhashtab
Name        Id                  Version Source
-----------------------------------------------
OpenHashTab namazso.OpenHashTab 2.3.0   winget

Maybe an issue on their side that needs to be reported/resolved. It looks like their CI didn't like so maybe it's related.

djdv avatar Jul 18 '21 10:07 djdv

Digging this issue up a bit because, if i remember correctly, v3.0.1 was showing up at one point in the winget tool.

Also, I'd like to risk a barely educated guess: can this issue be caused by the "v" prefix? It's only on the 3.0.1 release, and not on the 2.3.0 one. Moreover, I believe it would make sense for an upgrade tool to put letters before numbers in its ordering system, because of some release going "alpha x" or "beta y" before 1.0.

Edit: somebody encountering the same problem with v-prefixes and it's been classified as a bug, so it's on winget's side.

NotaInutilis avatar Sep 20 '21 13:09 NotaInutilis

Also, I'd like to risk a barely educated guess: can this issue be caused by the "v" prefix? It's only on the 3.0.1 release, and not on the 2.3.0 one.

You're right. I have created a PR to fix this:

  • #188

As for auto-updating the Winget manifest, I have also created a PR to setup the Winget Releaser workflow:

  • #189

sitiom avatar Jul 26 '23 02:07 sitiom

This was fixed on the Winget side already:

image

namazso avatar Jul 26 '23 08:07 namazso

This was fixed on the Winget side already:

image

That's because the 2.x versions were removed in Winget: https://github.com/microsoft/winget-pkgs/pull/39284, https://github.com/microsoft/winget-pkgs/pull/39285. I think the better solution was to trim off the v prefix on the OpenHashTab side.

sitiom avatar Jul 26 '23 09:07 sitiom

There seems to still be some wonky stuff with winget. It didn't upgrade OpenHashTab from 3.0.2 to 3.0.4 automatically with upgrade --all, I had to specifically ask for this package to upgrade. Plus, the v prefix does not appear in OpenHashTab's Check update window, having a version x instead, so it'd better be cut off (or added) everywhere for consistency. (And thanks you all folks for taking care of this sofware! Still very easy to use!)

NotaInutilis avatar Jul 26 '23 10:07 NotaInutilis