OpenHashTab icon indicating copy to clipboard operation
OpenHashTab copied to clipboard

Feature Request: Stop calculating & Change algorithm immediately

Open nkh0472 opened this issue 5 years ago • 6 comments

Generally, calculating the hash value of a large file is a long and painful thing. Worst of all, different websites often give different file verification algorithms. In order to save time, I often only open the corresponding algorithm for calculation. Therefore, there is a need to temporarily replace the verification algorithm.

At present, this software can only replace the calculation algorithm after the calculation is completed. For large files, it takes more than twice the time to wait for the calculation to complete, modify the options, close the window and re-enter. Therefore, if you can add a button to interrupt the current calculation, and can effectively modify the algorithm immediately for calculation (no need to close the window and re-enter), it will be very convenient. image image

nkh0472 avatar Nov 06 '20 02:11 nkh0472

aborting calculation is a thing implemented in code already, i'll try to make space for a button. Where you drawn it on your picture it would be out of the window on non dpi scaling systems (related: #29 ) as for recalculation, it might be a bit more complex issue, since it requires disabling buttons and restoring some other stuff, but i can maybe sidestep this by "secretly" deleting and recreating the tab.

namazso avatar Nov 06 '20 08:11 namazso

If recreating tab works, the stop button is not necessary. Do not freeze the "gear" button during calculation is the simplest solution.

nkh0472 avatar Nov 06 '20 15:11 nkh0472

that would be far harder. the buttons are disabled because code isn't prepared for any of them being used. I'll think about redesigning this part, because this is also why you can't just add new files on the fly.

namazso avatar Nov 06 '20 16:11 namazso

Usually, when we want to compare file hash, we only need a specific algorithm. So why not choose the algorithm first and then calculate it, I mean, it is not necessary to calculate automatically. HashTools and QuickHash are both working like this.

nkh0472 avatar Nov 21 '20 00:11 nkh0472

Because there is no point doing that compared to allowing the user to change and restart calculation (as suggested here). When done the automatic way:

  • best case will make the next calculation faster because windows already caches the file due to the previous reads
  • worst case we just burned some cpu and did some pointless reads - who cares

namazso avatar Nov 21 '20 03:11 namazso

Should this issue be closed?

vertigo220 avatar Jul 09 '22 01:07 vertigo220