auto-skip-for-netflix-and-prime icon indicating copy to clipboard operation
auto-skip-for-netflix-and-prime copied to clipboard

Issues with german translation.

Open syl3r86 opened this issue 4 years ago • 4 comments

Hi, this plugin sadly doesn't work correctly using prime in german. Prime translates "skip intro" into "Vorspann überspringen", not "Intro überspringen". Was about to send a pull request to change the translation, but that might fuck up the Netflix integration, since they do use "Intro überspringen"....... this is a really stupid problem, and I'm sorry that it exists, but skipping the intro in prime is pretty much the reason for me to use the plugin (how I found it initially). Amazon: image Netflix: image

hope you can find a good solution 👍

syl3r86 avatar Nov 04 '20 20:11 syl3r86

@syl3r86 looks like they changed it recently.

But someone mentioned earlier, prime uses two versions of Skip intro translation. Sometimes they use "Intro überspringen" and sometimes "Vorspann überspringen", I think it depends on the show you are watching.

Check out this review left by a user on chrome web store. We need to make changes to the code to accommodate multiple translations.

PS: Netflix doesn't need the translation logic as they have well-defined selectors for skip intros. Translation logic is only for PrimeVideo.

image

naman03malhotra avatar Nov 06 '20 18:11 naman03malhotra

Continue to discuss this at: https://github.com/naman03malhotra/auto-skip-for-netflix-and-prime/issues/30

naman03malhotra avatar Nov 11 '20 09:11 naman03malhotra

Fixed with v3.3.4

naman03malhotra avatar Nov 20 '20 07:11 naman03malhotra

On another note, Netflix seems to have changed it recently image I will create a PR

But shouldn't there be separate prime & netflix translation entries instead?

EDIT: just saw this.

We need to make changes to the code to accommodate multiple translations.

inxomnyaa avatar Sep 11 '21 20:09 inxomnyaa