Nalin Dahyabhai

Results 221 comments of Nalin Dahyabhai

Hang on, if the contents of the additional build context are the same as, or changed from, on a previous run, do we, or do we not want to reuse...

> I think cache stopped working for --mount when additional build context is used as source after PR #4526 Stopped working _how_? Did it fail to find a suitable image...

The "now works" in the release note still doesn't describe what was fixed. Are cached images used where they weren't before? Are they not when they shouldn't have been? Does...

I'm surprised that we'd care about the contents of caches. I'd be inclined to archive the contents of a directory (and create a single-entry archive for a non-directory) to account...

> > I'm surprised that we'd care about the contents of caches. I'd be inclined to archive the contents of a directory (and create a single-entry archive for a non-directory)...

In its current form, this considers caches where a "src" option is used to select a subdirectory, but not otherwise. It should either check the mount type and skip caches,...

IIRC we started filling in the host's variant in cases where the target platform isn't specified, in an attempt to more closely mimic the behavior of `docker build`.

This isn't going to work as intended when the destination for a COPY with a heredoc is a directory - the destination file's name should be the same as the...