pandarallel
pandarallel copied to clipboard
Add option to show single progress bar for all workers
As of now, each worker has its own progress bar, but it would be nice to have a summary bar for all workers, since sometimes it will be too cluttered to show all progress bars when the number of workers are too high, as mentioned in https://github.com/nalepae/pandarallel/issues/134
I implemented this feature to allow users to pass an argument to pandarallel.initialize
to select to use only one progress bar. The test results are shown below:
Codecov Report
Merging #203 (1a8ff07) into master (a402a03) will decrease coverage by
1.17%
. The diff coverage is52.94%
.
@@ Coverage Diff @@
## master #203 +/- ##
==========================================
- Coverage 91.47% 90.30% -1.18%
==========================================
Files 12 12
Lines 575 588 +13
==========================================
+ Hits 526 531 +5
- Misses 49 57 +8
Impacted Files | Coverage Δ | |
---|---|---|
pandarallel/progress_bars.py | 70.45% <38.46%> (-3.93%) |
:arrow_down: |
pandarallel/core.py | 91.97% <100.00%> (+0.08%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Hi @ApolloBian,
thanks for your contribution! I personally like this feature and I see it has been requested by other users, but I don't know what @nalepae's stance is.
Something that I would like to see before merging is tests. As far as I'm concerned, this can just be turning the feature off and on, as we do with progress bars in general.
@nalepae as a sidenote, I think it would be good to enable workflows to run automatically/without approval from maintainers. I don't see any possibilities of the current workflow being used maliciously, but it would speed up development.
@till-m
It's the most permissive I can do :)
any chance this is gonna be merged soon?
Hey @lpuglia, after the requested changes are implemented this would principally be ready for merge.
Hey @till-m @ApolloBian @nalepae @lpuglia, is there anything missing for this to be merged? I can help if that's the case.
Hey @victormaricato, there's a few PR's attempting to tackle this problem but none of them are currently ready to merge: (this), #239 and #243.
Pandaral·lel is looking for a maintainer! If you are interested, please open an GitHub issue.