zho

Results 35 comments of zho

@benschac Hmm i think we have one problem here, it is because we are using `TransactionModal` in these files that I'm applying. Thing is, but you may know this is...

> Following up from discord. Your implementation works as expected with the pending modal shown after the `claim` button is fixed. > > I think there's a bug in the...

> Cross post from discord: https://discord.com/channels/939317843059679252/1012735432515129446/1013077786031829082 @benschac can you review this one more time when you have a chance ser? 🍻

> I had to quick questions: > > * It looks like `public/vendor/desmos/calculator.min.js` was related to a different PR / might have got mixed into this PR accidently. Could you...

> @NakedFool checking in on this one. Can I help with anything to get this merged? code-wise, everything is good; we only need to be sure we need this `calculator.min.js`...

> @NakedFool just one last comment! I've updated the branch with the latest changes, take a look when you have a chance!

@johnnyd-eth do you happen to remember which projects are affected by this? some projects I just checked now with infinite dist had owner percentage

@johnnyd-eth Is this now connected to this fix? https://github.com/jbx-protocol/juice-interface/pull/1806

Ignore above, just found that this project has that issue - https://juicebox.money/@dcfcdao Investigating issue.

Hmm after looking into this, i actually like how loading logic is done in v1 for history FC, instead of waiting for all cycles to load it is loading cycle...