nahsra
Upgrade neko-htmlunit to 4.20.0 with test fix
@davewichers I don't understand the error, never happened to me before. On my local environment it gives the same if I run mvn site.
@spassarop - I bumped google-java-format to version 1.17.0 (since I have Java 21 installed) and this issue went away, but then it says the method: containsStringIgnoreCase doesn't exist for class: AntiSamyTest. Did you forget to check in that new method? Can you bump google-java-format to version 1.17.0 and see if that works for you, and if so, check in that change along with the 'missing' method? This new format version also reformats the test class file so you have to check in those changes too.
@spassarop - htmlunit 4.20.0 just came out, but it doesn't change the 'uppercasing' behavior.
Made the changes and also upgraded to 4.20.0. However, until we don't have an answer for the uppercase behavior this will be on hold.
@spassarop - OK I tested this on both Windows and Linux and all the tests now pass and mvn site works. I also tested using both Java 17 and Java 21 and both work fine. Can you get in touch with @rbri to try to get our questions answered.
Also, some of your commits are verified but most are not. Can you make sure your git setup is the same on all machines/environments so your commits are all verified? Thx
@rbri Read the entire thread for PR https://github.com/nahsra/antisamy/pull/649. Our questions to you are in that thread. Thx
@rbri & @davewichers - I think @rbri is having difficultly finding it because most of those comments are from PR #649, not this PR.
Specifically, I think Dave is referring to the questions I asked about the impact on xHTML that are discussed in https://github.com/nahsra/antisamy/pull/649#issuecomment-3621141703 and https://github.com/nahsra/antisamy/pull/649#issuecomment-3627280584. Thanks.
I guess i know what happens here, will work on that and propose possible solutions.
@spassarop @davewichers i think this was really a bug. Hopefully the behaviour is not fixed and also a bit more documented. (https://github.com/HtmlUnit/htmlunit-neko?tab=readme-ov-file#tag-case-handling)
Please try the 4.20.1-SNAPSHOT build and give me a sign if your are happy with this. Will do a release 4.20.1 for you.
@kwwall - Thanks for pointing out the upper vs. lowercase issue for xHTML. @spassarop - Let me know how your testing goes with this 'fixed'' snapshot. And if it fixes things then I think we can revert our code/test changes and simply upgrade to the version of htmlunit-neko. We also need to upgrade our formatting library config so they work with Java 17/21, but that's a separate issue.
I will do the test on Sunday, I won’t have access to my testing environment before that. I’ll tell you by then.
Il giorno ven 12 dic 2025 alle 11:27 Dave Wichers @.***> ha scritto:
davewichers left a comment (nahsra/antisamy#656) https://github.com/nahsra/antisamy/pull/656#issuecomment-3646694398
@kwwall https://github.com/kwwall - Thanks for pointing out the upper vs. lowercase issue for xHTML. @spassarop https://github.com/spassarop
- Let me know how your testing goes with this 'fixed'' snapshot. And if it fixes things then I think we can revert our code/test changes and simply upgrade to the version of htmlunit-neko. We also need to upgrade our formatting library config so they work with Java 17/21, but that's a separate issue.
— Reply to this email directly, view it on GitHub https://github.com/nahsra/antisamy/pull/656#issuecomment-3646694398, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHL3BMJLTXSPVLO4HTCVTWD4BLGFTAVCNFSM6AAAAACOIEVBFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMNBWGY4TIMZZHA . You are receiving this because you were mentioned.Message ID: @.***>
@rbri I tried referencing the snapshot but my device cannot find it. This is my snapshot repository:
<snapshotRepository>
<id>ossrh</id>
<url>https://oss.sonatype.org/content/repositories/snapshots</url>
</snapshotRepository>
```
@spassarop yes, the sonatype folks have changed there infrastructure, find the current details here https://github.com/HtmlUnit/htmlunit-neko#maven-1
Thanks @rbri, the snapshot is fine with all tests. @davewichers, I think the best is to just bump the new version when Ronald releases it and discard this PR. No code changes are needed after that.
Closing as upgraded to 4.20.1 by hand. @rbri - thanks for fixing and pushing a new release!