antisamy icon indicating copy to clipboard operation
antisamy copied to clipboard

Test Case JavaDoc Issues w/ Java 11+

Open davewichers opened this issue 2 years ago • 1 comments

I noticed when I upgraded to Java 11 and Java 16, then ran: mvn clean site, I'm getting lots of JavaDoc errors I don't get with Java 7 or 8. For example:

100 warnings [WARNING] Javadoc Warnings [WARNING] javadoc: warning - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/7/docs/api/ are in the unnamed module. [WARNING] /Users/Dave.Wichers/git/ANTISAMY/antisamy_main/src/test/java/org/owasp/validator/html/TagMatcherTest.java:39: warning: no comment [WARNING] public void testMatchesIgnoreCase() throws Exception { [WARNING] ^ [WARNING] /Users/Dave.Wichers/git/ANTISAMY/antisamy_main/src/test/java/org/owasp/validator/html/model/TagTest.java:29: warning: no comment [WARNING] public void testGetRegularExpression() throws Exception { [WARNING] ^ [WARNING] /Users/Dave.Wichers/git/ANTISAMY/antisamy_main/src/test/java/org/owasp/validator/html/model/TagTest.java:20: warning: no comment [WARNING] public void testSimpleRegularExpression() throws Exception { [WARNING] ^ ... and many more.

@spassarop - Can you update the test cases to eliminate these warnings when you get some time? Not urgent, and certainly something we can do post the 1.6.5 release. I use 'jenv' to easily switch from one Java version to another per directory.

davewichers avatar Dec 29 '21 18:12 davewichers

In JDK 9, there was a new Doclet API introduced, which probably affected the Javadoc tool so that it now complains about different stuff. E.g., see https://openjdk.java.net/groups/compiler/using-new-doclet.html. There are probably other more informative posts, but this is probably one reason you are seeing a difference.

kwwall avatar Jan 09 '22 02:01 kwwall