Test failures in httpclient 2.2.6

[graaff]

I'm seeing several test failures in httpclient 2.2.6. I assume these happen because you seem to assume that localhost == 127.0.0.1. These are not the same, and in fact on my system localhost == ::1

  1) Error:
test_digest_proxy_auth(TestAuth):
HTTPClient::BadResponseError: unexpected response: #<HTTP::Message::Headers:0x7f9b3c534948 @body_date=nil, @status_code=503, @header_item=[["Content-Length", "323"], ["Server", "WEBrick/1.3.1 (Ruby/1.8.7/2012-06-29) OpenSSL/1.0.0j"], ["Content-Type", "text/html; charset=ISO-8859-1"], ["Date", "Tue, 14 Aug 2012 18:54:45 GMT"], ["Connection", "close"], ["Authentication-Info", "qop=\"auth\", rspauth=\"968826bdcdc5764bf7227a33c56a289d\", nc=00000001, nextnonce=\"MDAxMzQ0OTcwNDg1OmE4Mzg2NmRhYTQ5ZDJkN2JhMmIwY2Y1YTdmYzgzZTBi\", cnonce=\"MDAxMzQ0OTcwNDg1OmFhZTAxMzNmY2M2ODJkZDI2Y2M2MmZlODdjNWI0N2Mx\""]], @request_method="GET", @body_charset=nil, @request_absolute_uri=nil, @is_request=false, @body_size=0, @body_type=nil, @request_query=nil, @body_encoding=nil, @http_version="1.1", @reason_phrase="Service Unavailable ", @chunked=false, @dumped=false, @request_uri=#<URI::HTTP:0x7f9b3c53eec0 URL:http://127.0.0.1:37181/basic_auth>>
    ./lib/httpclient.rb:960:in `success_content'
    ./lib/httpclient.rb:580:in `get_content'
    ./test/test_auth.rb:244:in `test_digest_proxy_auth'

  2) Error:
test_get_content(TestHTTPClient):
Errno::ECONNREFUSED: Connection refused - connect(2) (http://127.0.0.1:43634)
    ./lib/httpclient/session.rb:800:in `initialize'
    ./lib/httpclient/session.rb:800:in `new'
    ./lib/httpclient/session.rb:800:in `create_socket'
    ./lib/httpclient/session.rb:749:in `connect'
    ./lib/httpclient/timeout.rb:131:in `timeout'
    ./lib/httpclient/session.rb:748:in `connect'
    ./lib/httpclient/session.rb:606:in `query'
    ./lib/httpclient/session.rb:161:in `query'
    ./lib/httpclient.rb:1070:in `do_get_block'
    ./lib/httpclient.rb:873:in `do_request'
    ./lib/httpclient.rb:966:in `protect_keep_alive_disconnected'
    ./lib/httpclient.rb:872:in `do_request'
    ./lib/httpclient.rb:945:in `follow_redirect'
    ./lib/httpclient.rb:580:in `get_content'
    ./test/test_httpclient.rb:497:in `test_get_content'

  3) Error:
test_socket_local(TestHTTPClient):
Errno::EINVAL: Invalid argument - bind(2) (http://localhost:42244)
    ./lib/httpclient/session.rb:802:in `initialize'
    ./lib/httpclient/session.rb:802:in `new'
    ./lib/httpclient/session.rb:802:in `create_socket'
    ./lib/httpclient/session.rb:749:in `connect'
    ./lib/httpclient/timeout.rb:131:in `timeout'
    ./lib/httpclient/session.rb:748:in `connect'
    ./lib/httpclient/session.rb:606:in `query'
    ./lib/httpclient/session.rb:161:in `query'
    ./lib/httpclient.rb:1070:in `do_get_block'
    ./lib/httpclient.rb:873:in `do_request'
    ./lib/httpclient.rb:966:in `protect_keep_alive_disconnected'
    ./lib/httpclient.rb:872:in `do_request'
    ./lib/httpclient.rb:945:in `follow_redirect'
    ./lib/httpclient.rb:580:in `get_content'
    ./test/test_httpclient.rb:1463:in `test_socket_local'

[nahi]

Yes, you're right. I should clean-up IPv4 dependency from the test suite... (It's the problem of test suite, not HTTPClient)