Matthias Nagel
Matthias Nagel
I guess you want to start your development branch on top of master? The main differences between the re-factored architecture of the albums and the current master branch is the...
There is a pending PR #1195 which will introduce markdown support. It will also allow to add a description to each album which can be displayed below the title. I...
> I just want to add a return back to my website text with link The markdown PR will also supports links via the markdown syntax `[description](url)`. However, for your...
> Wouldn't we want this to be a proper DTO directly ? In theory yes. But I already left that one out on purpose when I introduced the DTOs. The...
> Untested, LGTM. I guess the DTO will wait a proper refactoring on that part (I read your mind :D). Exactly. This is only a quick fix, so that we...
The question is whether we should wait until #1403.
After https://github.com/LycheeOrg/Lychee/pull/1403 has been merged into the backend, this PR needed to adopt. So I think it should be re-reviewed. The following aspects have been changed (also see https://github.com/LycheeOrg/Lychee-front/pull/310): 1....
> LGTM. [...] > > I am wondering if we want this duplication of _rights_, or if we just don't care in this specific case. :) Because they only happen...
I agree that this would be plus. Give the current state of the backend it would be difficult to implement it as the state of visibility of a photo is...
I know. My post wasn't meant to put more workload onto you, but to inform the original poster that the idea is great but may have to wait some time....