dsnet icon indicating copy to clipboard operation
dsnet copied to clipboard

Error cascade

Open xxxserxxx opened this issue 3 years ago • 3 comments

This version (which can be merged on top of, or instead of, report_errors) replaces ExitFail() in the top-level functions, such that errors are passed up to the main function and reported there. Long-term, ExitFail() would ideally be removed entirely; by exiting deep in the stack, it prevents calling functions the opportunity to handle and clean up after errors. However, this PR focuses on having consistent behavior in all of the top-level commands by using RunE() wherever there can be failures.

xxxserxxx avatar Aug 11 '22 10:08 xxxserxxx

All of these PRs are based on different branches, and they often conflict. If you're going to pull any of them, I recomend pulling issue-69 and user-keys-master first, then letting me know which others you do (or don't) want to merge, and letting me resolve the conflicts.

xxxserxxx avatar Aug 12 '22 16:08 xxxserxxx

Thanks @xxxserxxx -- I will get the user-keys-master branch merged first I think. A useful change and helps @botto 's plight of separating the cli into a lib. @botto please take a look too.

naggie avatar Sep 13 '22 20:09 naggie

Rebased naggie/master onto this so it's a clean merge again.

xxxserxxx avatar Nov 04 '22 13:11 xxxserxxx