subtotal icon indicating copy to clipboard operation
subtotal copied to clipboard

Put Row SubTotals at Bottom Instead of Top

Open j8lp opened this issue 8 years ago • 31 comments

Is there a way we can put the row subtotals at the bottom of its parent row instead of at the top of its parent row. For example: http://nagarajanchinnasamy.com/subtotal/examples/

Is there a way we can get the total number of Female Voters to appear at the bottom of the Female row instead of at the top?

j8lp avatar Sep 21 '16 00:09 j8lp

Hi, Currently its not possible to put the subtotals as the last row of the parent. I will take this as an enhancement request and if it doesn't impact the performance, I will try to implement it. If implemented, I will make it configurable through an option.

Thanks for the feedback.

nagarajanchinnasamy avatar Sep 28 '16 11:09 nagarajanchinnasamy

Hey @nagarajanchinnasamy Any progress on this ? any idea how I could do that easily ? Been trying for quite a long time and I have to say I'm struggling. Also any idea how to not display subtotals when expanding ? Thanks. Damien.

Dams591 avatar Dec 28 '16 14:12 Dams591

To me the secret is inside buildRowHeaders, but can't modify it easily.

Dams591 avatar Dec 28 '16 14:12 Dams591

Hiding subtotals when expanding is addressed in #26

nagarajanchinnasamy avatar Jan 31 '17 13:01 nagarajanchinnasamy

@j8lp @Dams591 When I started writing this plugin, unknowingly :( I have made a strong assumption that the subtotal row goes on top. This will need major refactoring of the code.

I will keep this in my TODO list definitely. But will need more time.

nagarajanchinnasamy avatar Jan 31 '17 13:01 nagarajanchinnasamy

As @Dams591 put it rightly, the secret is in buildRowHeaders. But it shouldn't be that difficult :)

One of you want to give it a try? Otherwise, i will come to this after completing work on "Hide On Expand" feature.

nagarajanchinnasamy avatar Feb 02 '17 12:02 nagarajanchinnasamy

I'm still integrating the hide on expand into my solution, since I have the multiple values on and some other things I'm having a tough time but I'm getting there. Once I have it I'll give it a try. Let me come back to you in 2-3 days.

Dams591 avatar Feb 02 '17 12:02 Dams591

I guess, we just need to alter the way recursion is done. No other changes may be needed.... hopefully :)

nagarajanchinnasamy avatar Feb 02 '17 15:02 nagarajanchinnasamy

Just played around changing the method of recursion. It does not help. It is tough!!!

nagarajanchinnasamy avatar Feb 02 '17 23:02 nagarajanchinnasamy

Points to remember are:

  • Current logic makes use of row-span, which is always upper-row-to-lower-row expansion in HTML
  • Expand and Collapse operations affect the parent header's row-span values

So, the secret is in buildRowHeaders, collapseRow and expandRow functions :)

nagarajanchinnasamy avatar Feb 04 '17 08:02 nagarajanchinnasamy

Repsected

I just tried to modified buildRowHeaders function to bind subtotal below the row, but nothing happened. So please try on that to resolve this issue.

Thanks

Kishan1824 avatar May 08 '17 05:05 Kishan1824

Respected

Is there any way to display sub-total below the row. If possible then please suggest.

Waiting for positive reply.

Thanks

Kishan1824 avatar Jun 06 '17 10:06 Kishan1824

Hey @nagarajanchinnasamy
Did you have the time to work on this ? Still can't figure it out :(

Dams591 avatar Aug 14 '17 14:08 Dams591

Sorry for the delayed response. I am working on it. Scheduled for release v1.11.0.. May take couple of more weeks minimum.

nagarajanchinnasamy avatar Sep 17 '17 12:09 nagarajanchinnasamy

Yes please create this Subtotal at the bottom option. It is very important. Thanks

hkbeer avatar Sep 20 '17 05:09 hkbeer

Column Collapsing, Row collapsing and showing row subtotals at the bottom implemented. Please check latest v1-11.0 branch. Pending: Row expansion when displaying subtotals at the bottom.

Am using examples/210_collapse_rowscols.html to test and debug.

nagarajanchinnasamy avatar Sep 30 '17 16:09 nagarajanchinnasamy

Dear Sir

I have tested your updated version of subtotal.js for displaying row subtotal in below portion of row. Its working but now my subtotal for column is not working properly after this update.

Please check attached files as error in my case. Waiting for positive reply.

On Sat, Sep 30, 2017 at 9:38 PM, Nagarajan Chinnasamy < [email protected]> wrote:

Column Collapsing, Row collapsing and showing row subtotals at the bottom implemented. Please check latest v1-11.0 branch https://github.com/nagarajanchinnasamy/pivottable-subtotal-renderer/tree/v1-11.0. Pending: Row expansion when displaying subtotals at the bottom.

Am using examples/210_collapse_rowscols.html https://github.com/nagarajanchinnasamy/pivottable-subtotal-renderer/blob/v1-11.0/examples/210_collapse_rowscols.html to test and debug.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nagarajanchinnasamy/pivottable-subtotal-renderer/issues/12#issuecomment-333318365, or mute the thread https://github.com/notifications/unsubscribe-auth/AS5TBPYPSOWvxOVe9LJg6CrcToI_D1f2ks5snmdygaJpZM4KCSPG .

Kishan1824 avatar Oct 04 '17 06:10 Kishan1824

@KishanManali1824 and friends,

Please check the latest version at v1-11.0 branch. I will merge this branch into master after your confirmation.

Thanks :)

nagarajanchinnasamy avatar Nov 26 '17 11:11 nagarajanchinnasamy

Respected

Let me check it. Reply you back.

Thanks for updation.

On Nov 26, 2017 5:07 PM, "Nagarajan Chinnasamy" [email protected] wrote:

@KishanManali1824 https://github.com/kishanmanali1824 and friends,

Please check the latest version at v1-10.0 branch. I will merge this branch into master after your confirmation.

Thanks :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nagarajanchinnasamy/pivottable-subtotal-renderer/issues/12#issuecomment-347002383, or mute the thread https://github.com/notifications/unsubscribe-auth/AS5TBNhR-E6SCXGrq6_lGiaU19vuL_SQks5s6U19gaJpZM4KCSPG .

Kishan1824 avatar Nov 27 '17 04:11 Kishan1824

Respected @nagarajanchinnasamy

Its working fine for Row Sub-Total Display Below Property. Thanks for great work. Now can i achieve this below requirement in same updation. Please check my below issue.

I want demo1.png image report type Row & Column Sub-Total Label in our new demo2.png report. Please check both images. demo1 demo2

Kishan1824 avatar Nov 27 '17 06:11 Kishan1824

Respected @nagarajanchinnasamy

I found one issue in updation. See my attachment. Waiting for reply. demo3

Kishan1824 avatar Nov 27 '17 09:11 Kishan1824

@KishanManali1824 Thanks for testing :)

Thats not an issue. Its an enhancement implemented to show the details in the same line when the number of children is one. In your case, RAIL has only one child NORTH. So, the details of NORTH and RAIL will be same. Instead of repeating the same details for RAIL and NORTH, we now show the details in one single row. Hope that explains.

nagarajanchinnasamy avatar Nov 27 '17 12:11 nagarajanchinnasamy

Respected

Thats ok,now can we achieve that Row-Sub-Total & Column-Sub-Total Header Label as i described before on github?.

On Mon, Nov 27, 2017 at 6:14 PM, Nagarajan Chinnasamy < [email protected]> wrote:

@KishanManali1824 https://github.com/kishanmanali1824 Thanks for testing :)

Thats not an issue. Its an enhancement implemented to show the details in the same line when the number of children is one. In your case, RAIL has only one child NORTH. So, the details of NORTH and RAIL will be same. Instead of repeating the same details for RAIL and NORTH, we now show the details in one single row. Hope that explains.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nagarajanchinnasamy/pivottable-subtotal-renderer/issues/12#issuecomment-347171326, or mute the thread https://github.com/notifications/unsubscribe-auth/AS5TBKv-Bp0OxYwEl59UXWgXVdjZ6-blks5s6q7CgaJpZM4KCSPG .

Kishan1824 avatar Nov 28 '17 04:11 Kishan1824

@KishanManali1824

Thats not addressed in this version. Please create a new issue to track it separately.

One small request :) Please feel free to address me as @nagarajanchinnasamy 👍

nagarajanchinnasamy avatar Nov 28 '17 20:11 nagarajanchinnasamy

@nagarajanchinnasamy https://github.com/nagarajanchinnasamy

Ok.I have created new issue related to Row Sub-Total Header Label implementation on github. refer link : https://github.com/nagarajanchinnasamy/pivottable-subtotal-renderer/issues/53

Waiting for positive reply.

On Wed, Nov 29, 2017 at 2:24 AM, Nagarajan Chinnasamy < [email protected]> wrote:

@KishanManali1824 https://github.com/kishanmanali1824

Thats not addressed in this version. Please create a new issue to track it separately.

One small request :) Please feel free to address me as @nagarajanchinnasamy https://github.com/nagarajanchinnasamy 👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nagarajanchinnasamy/pivottable-subtotal-renderer/issues/12#issuecomment-347660332, or mute the thread https://github.com/notifications/unsubscribe-auth/AS5TBBSAxNSAKjvKVxRcCVErwL4ScG2Eks5s7HMRgaJpZM4KCSPG .

Kishan1824 avatar Nov 29 '17 04:11 Kishan1824

@nagarajanchinnasamy

I want to show the row sub-total when the number of children is one. Currently when children is one then that row sub-total not coming.

Please help as needed. Waiting for positive reply.

On Nov 27, 2017 6:14 PM, "Nagarajan Chinnasamy" [email protected] wrote:

@KishanManali1824 https://github.com/kishanmanali1824 Thanks for testing :)

Thats not an issue. Its an enhancement implemented to show the details in the same line when the number of children is one. In your case, RAIL has only one child NORTH. So, the details of NORTH and RAIL will be same. Instead of repeating the same details for RAIL and NORTH, we now show the details in one single row. Hope that explains.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nagarajanchinnasamy/pivottable-subtotal-renderer/issues/12#issuecomment-347171326, or mute the thread https://github.com/notifications/unsubscribe-auth/AS5TBKv-Bp0OxYwEl59UXWgXVdjZ6-blks5s6q7CgaJpZM4KCSPG .

Kishan1824 avatar Dec 07 '17 06:12 Kishan1824

@KishanManali1824

In the latest v1.11.0-alpha.0 release now we show subtotal when a parent number of children is 1. Please check and let me know if there are any issues.

Thanks for your feedback 👍

nagarajanchinnasamy avatar Dec 07 '17 06:12 nagarajanchinnasamy

Hey @nagarajanchinnasamy https://github.com/nagarajanchinnasamy

Its working fine.Thanks for updation. You are working like champ😎.

One small request can we export the same pivot html wihout those expand/collapse icon in excel. I have already done it but some issue's going. can u help in it.

Waiting for positive reply.

On Thu, Dec 7, 2017 at 12:29 PM, Nagarajan Chinnasamy < [email protected]> wrote:

@KishanManali1824 https://github.com/kishanmanali1824

In the latest v1.11.0-alpha.0 release https://github.com/nagarajanchinnasamy/subtotal/releases/tag/v1.11.0-alpha.0 now we show subtotal when a parent number of children is 1. Please check and let me know if there are any issues.

Thanks for your feedback 👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nagarajanchinnasamy/subtotal/issues/12#issuecomment-349880552, or mute the thread https://github.com/notifications/unsubscribe-auth/AS5TBH8SfA7vrom12nPjSQ-D6K92rbe3ks5s94zOgaJpZM4KCSPG .

Kishan1824 avatar Dec 07 '17 10:12 Kishan1824

Pls create a separate issue regarding download. Thanks :-)

nagarajanchinnasamy avatar Dec 07 '17 21:12 nagarajanchinnasamy

OK. i will create a separate issue for that. Also created another issue regarding sub-total header label.

Check & confirm. Waiting for positive reply.

On Fri, Dec 8, 2017 at 3:06 AM, Nagarajan Chinnasamy < [email protected]> wrote:

Pls create a separate issue regarding download. Thanks :-)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nagarajanchinnasamy/subtotal/issues/12#issuecomment-350101590, or mute the thread https://github.com/notifications/unsubscribe-auth/AS5TBIDvC3wS6vjWZiBwVqsGyvq-hJbUks5s-FpVgaJpZM4KCSPG .

Kishan1824 avatar Dec 08 '17 04:12 Kishan1824