Naftali Beder

Results 47 comments of Naftali Beder

@natew Thanks for doing this and I support the overall direction of compiling as part of the publish step. I'll leave it to @mfazekas to decide whether this is the...

@natew Regarding the test failure of the pattern > 'MapView' cannot be used as a JSX component. I had the same thing in my now-cancelled Typescript conversion PR, and the...

> BTW if you look at `react-native-reanimated` they also point to `src/index` and not to `lib/...` for `react-native` . > Same one for `react-native-paper` @mfazekas it is worth noting that...

@mfazekas are you able to develop on this project locally, as in `npm install /my/local/clone/maps` in a parent RN project? If so, can you describe what your setup is? I...

> I'm mostly using yarn, and I'm usually install from GitHub, (Btw. `npm link` would be awesome but symlinks don't work with metro used by RN). I'll try npm install...

It does look like there's still a bug - after every "rearrange", there are supposed to be 10 markers, and it looks like there's frequently fewer. Still investigating. https://user-images.githubusercontent.com/2423291/191126658-f623acbe-b7ff-4584-b5f8-6f9e310087b9.mov

I've fixed the bug referenced above, so now all `MarkerView` components are correctly added. There were a few problems in the code, but the main one was that when each...

This turned out to be a much bigger `MarkerView` refactor than I was expecting. Changes so far: - Allow arbitrary number of children (instead of exactly 1) - Fix bug...

> So if the issue is, that that we add the annotation before reactSetFrame was called, why don't we just add when reactSetFrame was executed. So the problem is unfortunately...

> There is also a scheduleTimer which is also fishy in general - we sometimes resort to that but it's better avoided. Again, I agree, but I wasn't able to...