Naftoli Gugenheim

Results 587 comments of Naftoli Gugenheim

Perhaps to include non-releases the flag should be `--unstable` or `--all`. P.S. Speaking of Scala Steward, does it support Bleep? If not, perhaps support could be added -- and to...

> @nafg [Here](https://github.com/plokhotnyuk/jsoniter-scala/blob/ba695984ced7140c8571d9f1804c1660637aa569/jsoniter-scala-benchmark/shared/src/main/scala/com/github/plokhotnyuk/jsoniter_scala/benchmark/UPickleReaderWriters.scala#L195) is an example of more efficient extraction of class names. How is it more efficient? You mean using lastIndex and substring is more performant than split and...

> You're generally expected to use the `@key` annotation for customizing things for now But as you know that doesn't do the same thing.

And for reading? If you only care about writing it's one override either way, but in your case it involves other concerns too

Indeed, I suppose then that that is the correct way to do it. However it's not clear from the docs that that's what that does. In fact, when I was...

Or my refactor. Didn't see this before. I can look into it.

So I think the explanation for what changed is that previously it `foreach`ed over all the headers calling [setRequestProperty](https://docs.oracle.com/javase/8/docs/api/java/net/URLConnection.html#setRequestProperty-java.lang.String-java.lang.String-) for each one, which means _all_ headers will only end up...

Meaning, the other option would be that we should handle cases like content type specially, or headers from the request blob specially, or something like that.

Or, make it easier to override the content type of a RequestBlob