Fix deregisterInstance with groupName
修复deregisterInstance groupName 参数未起效,代码错误
Codecov Report
Merging #56 (76b6755) into master (2ea1abb) will decrease coverage by
73.79%. The diff coverage is15.38%.
@@ Coverage Diff @@
## master #56 +/- ##
===========================================
- Coverage 89.20% 15.40% -73.80%
===========================================
Files 19 10 -9
Lines 1028 675 -353
Branches 27 33 +6
===========================================
- Hits 917 104 -813
- Misses 101 571 +470
+ Partials 10 0 -10
| Impacted Files | Coverage Δ | |
|---|---|---|
| packages/nacos-config/src/http_agent.ts | 6.31% <0.00%> (-70.50%) |
:arrow_down: |
| packages/nacos-config/src/interface.ts | 100.00% <100.00%> (ø) |
|
| packages/nacos-config/src/server_list_mgr.ts | 7.25% <0.00%> (-86.08%) |
:arrow_down: |
| packages/nacos-config/src/client_worker.ts | 5.73% <0.00%> (-81.87%) |
:arrow_down: |
| packages/nacos-config/src/snapshot.ts | 19.56% <0.00%> (-80.44%) |
:arrow_down: |
| packages/nacos-config/src/configuration.ts | 5.55% <0.00%> (-76.27%) |
:arrow_down: |
| packages/nacos-config/src/client.ts | 10.28% <0.00%> (-52.08%) |
:arrow_down: |
| packages/nacos-config/src/index.ts | 14.28% <0.00%> (-39.05%) |
:arrow_down: |
| packages/nacos-config/src/utils.ts | 48.27% <0.00%> (-33.87%) |
:arrow_down: |
| ... and 3 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update d5e2dd8...76b6755. Read the comment docs.
Codecov Report
Merging #56 (76b6755) into master (2ea1abb) will decrease coverage by
73.79%. The diff coverage is15.38%.@@ Coverage Diff @@ ## master #56 +/- ## =========================================== - Coverage 89.20% 15.40% -73.80% =========================================== Files 19 10 -9 Lines 1028 675 -353 Branches 27 33 +6 =========================================== - Hits 917 104 -813 - Misses 101 571 +470 + Partials 10 0 -10Impacted Files Coverage Δ packages/nacos-config/src/http_agent.ts
6.31% <0.00%> (-70.50%)⬇️ packages/nacos-config/src/interface.ts100.00% <100.00%> (ø)packages/nacos-config/src/server_list_mgr.ts7.25% <0.00%> (-86.08%)⬇️ packages/nacos-config/src/client_worker.ts5.73% <0.00%> (-81.87%)⬇️ packages/nacos-config/src/snapshot.ts19.56% <0.00%> (-80.44%)⬇️ packages/nacos-config/src/configuration.ts5.55% <0.00%> (-76.27%)⬇️ packages/nacos-config/src/client.ts10.28% <0.00%> (-52.08%)⬇️ packages/nacos-config/src/index.ts14.28% <0.00%> (-39.05%)⬇️ packages/nacos-config/src/utils.ts48.27% <0.00%> (-33.87%)⬇️ ... and 3 more Continue to review full report at Codecov.Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update d5e2dd8...76b6755. Read the comment docs.
没人处理下吗?