nacos-sdk-go icon indicating copy to clipboard operation
nacos-sdk-go copied to clipboard

chore: update subscribe example annotations

Open jianghuosiliuying opened this issue 2 years ago • 3 comments

完善了example内的注释内容 明确出订阅和取消订阅需要使用同一个struct指针做操作

jianghuosiliuying avatar May 15 '22 07:05 jianghuosiliuying

@sanxun0325 这个pr什么时候可以合并呢?

jianghuosiliuying avatar May 18 '22 01:05 jianghuosiliuying

Codecov Report

:exclamation: No coverage uploaded for pull request base (2.0.0@e7d2324). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff            @@
##             2.0.0     #460   +/-   ##
========================================
  Coverage         ?   31.85%           
========================================
  Files            ?       37           
  Lines            ?     2665           
  Branches         ?        0           
========================================
  Hits             ?      849           
  Misses           ?     1754           
  Partials         ?       62           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e7d2324...a194591. Read the comment docs.

codecov-commenter avatar May 29 '22 11:05 codecov-commenter

@sanxun0325 这个pr什么时候可以合并呢?刚刚rebase了一下2.0分支最新的代码

jianghuosiliuying avatar Jul 17 '22 07:07 jianghuosiliuying

时间太久,暂时关闭,后面可以重新提交到master分支

binbin0325 avatar Sep 05 '22 02:09 binbin0325