aiosql icon indicating copy to clipboard operation
aiosql copied to clipboard

Dev

Open zx80 opened this issue 1 year ago • 6 comments

WIP

zx80 avatar Aug 20 '24 00:08 zx80

@zx80, I've not had a chance to clean up some of the current work, so there'd not been a PR for this; to the extent it helps any of the work you are doing now, I have an asnycmy adapter that may be useful. that I've not 100% tested, but works for the use case I had. I'll have the aiodbc and the oracle adapters tested soon as well.

cofin avatar Aug 20 '24 19:08 cofin

@zx80, I've not had a chance to clean up some of the current work, so there'd not been a PR for this; to the extent it helps any of the work you are doing now, I have an asnycmy adapter that may be useful. that I've not 100% tested, but works for the use case I had. I'll have the aiodbc and the oracle adapters tested soon as well.

Great! Thanks in advance for this and the future reports! In passing, if you could also test the PEP249 drivers with MS SQL et Oracle with the default adapters (which rely on paramstyle) that would be very nice!

zx80 avatar Aug 20 '24 23:08 zx80

@cofin would you consider contributing (some/all) of these adapters to aiosql, maybe?

zx80 avatar Aug 20 '24 23:08 zx80

@cofin would you consider contributing (some/all) of these adapters to aiosql, maybe?

@zx80 I'm totally fine with this. This is basically the process that led to the current DuckDB adapter. I also plan to create a Spanner and BigQuery adapter as time permits (if that would be ok?)

cofin avatar Aug 20 '24 23:08 cofin

@cofin would you consider contributing (some/all) of these adapters to aiosql, maybe?

@zx80 I'm totally fine with this. This is basically the process that led to the current DuckDB adapter. I also plan to create a Spanner and BigQuery adapter as time permits (if that would be ok?)

:+1: :smiley:

zx80 avatar Aug 21 '24 01:08 zx80

@zx80 I'll wait until you've finished your updates here before making more changes. However, I did propose one change that's really a minor "nit". Feel free to merge or not. Thanks again!

cofin avatar Aug 23 '24 14:08 cofin