Nico Barnafi

Results 12 comments of Nico Barnafi

First of all, thank you for reviewing this. I will include your comments as soon as possible. Let me further comment only on the second one: > 2. We need...

@drwells @peterrum Hi, sorry for the long wait, but I finished all of the required work. At some parts I did something slightly different to the requirements, but all major...

Ok, I just finished adding everything. @drwells regarding the points, I added them directly to the existing test, as the required modification mas minimal. For FEQ(2) there is no modification...

Ok, finished adding last comments :)

Thanks @drwells @peterrum for all the help!

> It looks like the CI found a small problem - this isn't compatible with PETSc 3.7 (the oldest version of PETSc we support). Can you add some version checks?...

> My mistake - I forgot to explain the test part. > > To get the correct version check in the test you should not use the preprocessor version check...

> My mistake - I forgot to explain the test part. > > To get the correct version check in the test you should not use the preprocessor version check...

> There are still some unused variable warnings that need to be fixed. While this patch is going on we are cleaning up our headers so it looks like you...

@drwells everything fine now! Except for some errors on a windows file upload. Not sure what it is, nor if I can do something about it, please let me know.