Nabil Freij comments

Results 554 comments of


                                            Nabil Freij

Template rework

Sorry it has taken me this long but I released ablog 0.11.0rc1. I did not want to release such a large change without at least a brief RC period. So...

Adds a warn when using both assume_spherical_screen() and propagate_with_solar_surface() context managers with reproject_to()

I would like a feature changelog and a unit test to ensure that the warning is raised please. Can you also rename the pull request.

Adds a warn when using both assume_spherical_screen() and propagate_with_solar_surface() context managers with reproject_to()

The precommit check is also failing, if you can fix that too please.

Adds a warn when using both assume_spherical_screen() and propagate_with_solar_surface() context managers with reproject_to()

I don't see the use case?

Adds a warn when using both assume_spherical_screen() and propagate_with_solar_surface() context managers with reproject_to()

I spoke to the other maintainers and they suggested that instead of the class, we can create a custom decorator (e.g., @sunpycontextmanager) that handles the entry/exit code. It should then...

Adds a warn when using both assume_spherical_screen() and propagate_with_solar_surface() context managers with reproject_to()

> @nabobalis Sorry for the delay! I've got the decorator in place and even wrote a test for it. Dealing with both the decorator and context managers was a bit...

Adds a warn when using both assume_spherical_screen() and propagate_with_solar_surface() context managers with reproject_to()

Can you update the branch and see if that fixes the tests. If not, then something is going on in this PR and we have to track that down.

Adds a warn when using both assume_spherical_screen() and propagate_with_solar_surface() context managers with reproject_to()

That looks ok, I wouldn't worry about it.

Adds a warn when using both assume_spherical_screen() and propagate_with_solar_surface() context managers with reproject_to()

Please do not @ reviewers unless it is urgent.

Adds a warn when using both assume_spherical_screen() and propagate_with_solar_surface() context managers with reproject_to()

Thanks for the PR @Deus1704