Nabil Freij comments

Results 554 comments of


                                            Nabil Freij

Use sample data in examples when not demonstrating download

Venus transit was updated to use sample data.

Fixed bug that prevents RotatedSunFrame instances from being pickled

Hi @EdBehn, thanks for the PR! A few comments would be that, like the astropy pull request will want a unit test and a bugfix changelog entry (they go here...

Links in the inheritance diagrams don't work

> While [sphinx-doc/sphinx#10576](https://github.com/sphinx-doc/sphinx/pull/10576) will fix in bug in Sphinx, I doubt the bugfix will be backported to releases prior to 5.0. Something in our dependency tree for the docs build...

`make_fitswcs_header` should have an option to set the unit

Makes sense to me.

Fido implement the "limited support" attributes available in IDL vso_search

@ejm4567 That is really strange that you had to edit the source file for BS4. I will have to run the python 2 tests to make sure that something isn't...

A cheat sheet for making PRs to sunpy?

Maybe if we delete the current PR template and have a link to a docs page/cheat sheet? astropy have this page: https://docs.astropy.org/en/latest/development/workflow/development_workflow.html I think we link to it in the...

A cheat sheet for making PRs to sunpy?

Either works for me.

Replace FILLVAL with np.nan in read_cdf()

Do the integer data have fill values too? If so, we shouldn't need to worry about DTYPE and just replace it wholesale.

Replace FILLVAL with np.nan in read_cdf()

They don't have a seperate fill value for INT data stored in the metadata?

Raise feedback message at first ever import of sunpy

@ehsteve if you have thoughts on the specific details you would like to see