angular-http-loader icon indicating copy to clipboard operation
angular-http-loader copied to clipboard

* Made use of http loader optional via param

Open nerdo opened this issue 9 years ago • 6 comments

There're some cases where one doesn't want the http loader to run on a domain, e.g. for some background AJAX call. For those times, this update looks for the absence of (default behavior) or the presence of a falsy config.params.$useHttpLoader flag to bypass using it.

nerdo avatar Jan 06 '16 20:01 nerdo

Hi,

Question about your use case for this - is it requests to certain URLs that you don't want the loader to show for (ie: https://github.com/wongatech/angular-http-loader/issues/28) OR are you after the ability to have the loader some times show, some times not, for the same urls?

For example:

WhitelistDomain('www.wonga.com') BlacklistUrl('www.wonga.com', 'my-url') means requests to www.wonga.com/my-url will never show the loader

chrisiconolly avatar Jan 07 '16 09:01 chrisiconolly

It could be either. The latter use case covers the former.

By specifying the parameter as a default to the resource, you can blacklist the url, but you always have the option to override it if necessary. On Thu, Jan 7, 2016 at 3:52 AM Chris Conolly [email protected] wrote:

Hi,

Question about your use case for this - is it requests to certain URLs that you don't want the loader to show for (ie: #28 https://github.com/wongatech/angular-http-loader/issues/28) OR are you after the ability to have the loader some times show, some times not, for the same urls?

For example:

WhitelistDomain('www.wonga.com') BlacklistUrl('www.wonga.com', 'my-url') means requests to www.wonga.com/my-url will never show the loader

— Reply to this email directly or view it on GitHub https://github.com/wongatech/angular-http-loader/pull/29#issuecomment-169613310 .

nerdo avatar Jan 07 '16 21:01 nerdo

I've updated the code running on our site (respondr.io) with the code from this PR (as we needed exactly this feature) and it works great. Thanks for the code :)

tobiasc avatar Jan 14 '16 03:01 tobiasc

@nerdo can you please update the documentation with this? README and demo site as well! Thanks

zazoomauro avatar Jan 19 '16 09:01 zazoomauro

Hmm, not sure what I did wrong there, but I added the documentation, or at least I tried to.

nerdo avatar Jan 19 '16 20:01 nerdo

has this not been pulled into master yet?

famagusta avatar May 28 '16 09:05 famagusta