phpvms icon indicating copy to clipboard operation
phpvms copied to clipboard

Discord Notifications Not Working to Settings (After New Update)

Open vAAGroup opened this issue 4 months ago • 2 comments

Describe the bug After the recent Discord settings change for public notifications we noticed that it is not taking into account the newest setting and following the rest of them. We have a public webhook that we only want to display new ranks being assigned and new awards so we have "Discord Award Message (Public)" and "Discord User Rank Changed (Public)" checked. They do not work unless "Discord Pirep Messages (Public)" is also checked but then we get the key PIREP events which we do not want. If we check "Discord Pirep Messages (Public)" then both rank changes and awards work normally, however if we deselect "Discord Pirep Messages (Public)" nothing populates. No errors show up in the logs either.

Version 7.0.0-dev+240228.5d0fb9

To Reproduce Steps to reproduce the behavior:

  1. Change the settings to have Discord Pirep Messages (Public), Discord User Rank Changed (Public), and Discord Award Message (Public), and then manually assign a new rank or award to the user. The notification will be sent to discord normally.
  2. Deselect "Discord Pirep Messages (Public)" and assign a new rank/award.
  3. New rank/award won't show up in discord.

Expected behavior Per the settings we should be able to send just ranks, just awards, or a combo of both without sending any PIREP data if it is deselected.

vAAGroup avatar Mar 03 '24 21:03 vAAGroup

7.0.0-dev+240228.143d92 Not reproducible in my side with disposable basic manual awarding. Not tested with automatic awarding. Did you clear all caches? imagen imagen

Someone can reproduce this issue?

avs-code avatar Mar 04 '24 10:03 avs-code

Very interesting. Affirm, cleared all caches before beginning the test phase and then between each attempts before reporting the bug.

vAAGroup avatar Mar 04 '24 17:03 vAAGroup

Updated today to 240306.43a594 and seems to be now working with the selected options!

vAAGroup avatar Mar 10 '24 19:03 vAAGroup