phpvms
phpvms copied to clipboard
Fare notes not being returned in collections
Even though the fare has notes, it is not being returned in the collection "notes":""
Version 7.0.0-dev+220328.e2226b
To Reproduce
- Go to Admin > Fares
- Edit one of your fares, add a note to it
- Find a suitable place to dump the fare (like a pirep or a flight or simbrief form etc)
- Check the dumped collection
Expected behavior Notes should be visible in the collection and we should be able to use it
Additional context This was working before, probably before laravel9 switch
{"id":1,"code":"Y","name":"Economy","price":75,"cost":10,"capacity":189,"type":0,"notes":"","active":true,"created_at":"2022-07-09T14:27:23.000000Z","updated_at":"2022-07-09T21:23:23.000000Z","pivot":{"subfleet_id":"1","fare_id":"1","price":null,"cost":null,"capacity":"189"}},
I checked the model and it looks ok. Also admin > fares work fine.
Could not find the root cause why it's value is not being returned back with collections or relationships.
Any news or clues for this @nabeelio ?
Hmm... I think it's probably Services/FareService:172