phpvms icon indicating copy to clipboard operation
phpvms copied to clipboard

Fare notes not being returned in collections

Open FatihKoz opened this issue 1 year ago • 1 comments

Even though the fare has notes, it is not being returned in the collection "notes":""

Version 7.0.0-dev+220328.e2226b

To Reproduce

  1. Go to Admin > Fares
  2. Edit one of your fares, add a note to it
  3. Find a suitable place to dump the fare (like a pirep or a flight or simbrief form etc)
  4. Check the dumped collection

Expected behavior Notes should be visible in the collection and we should be able to use it

Additional context This was working before, probably before laravel9 switch

image

{"id":1,"code":"Y","name":"Economy","price":75,"cost":10,"capacity":189,"type":0,"notes":"","active":true,"created_at":"2022-07-09T14:27:23.000000Z","updated_at":"2022-07-09T21:23:23.000000Z","pivot":{"subfleet_id":"1","fare_id":"1","price":null,"cost":null,"capacity":"189"}},

FatihKoz avatar Jul 09 '22 21:07 FatihKoz

I checked the model and it looks ok. Also admin > fares work fine.

Could not find the root cause why it's value is not being returned back with collections or relationships.

FatihKoz avatar Jul 09 '22 21:07 FatihKoz

Any news or clues for this @nabeelio ?

FatihKoz avatar Aug 27 '22 21:08 FatihKoz

Hmm... I think it's probably Services/FareService:172

nabeelio avatar Aug 29 '22 16:08 nabeelio