phpvms
phpvms copied to clipboard
nabeelio
Prompt when flight is not biddable anymore
Is your feature request related to a problem? Please describe. When bidding is enable, and multi bidding is disable; there is no UI feedback on why a certain flight is not biddable by user. This causes confusion to new comer.
Describe the solution you'd like Add/remove bid icon should turn red. When user click on bid it should prompt this flight is no longer available.
Describe alternatives you've considered By default hide flights that are no longer available (biddable). Supply a toggle button to make them visible.
Additional context
Suggested UI change.
What about hiding the bid icon/button if the flight is not available ? It will be much easier compared to changing the color of the icon with some more logical checks.
What about hiding the bid icon/button if the flight is not available ? It will be much easier compared to changing the color of the icon with some more logical checks.
Hiding works but there needs to be a way to unhide. Many times users likes to know what are all the flights configured in a VA.
I am talking about hiding the bid button/icon if that flight is already bidded by someone else.
Not talking about hiding the flight itself, so users will be able to see the flight but the bid icon/button will not be there.
On 30 Apr 2021 Fri at 13:46 Sims Smith @.***> wrote:
What about hiding the bid icon/button if the flight is not available ? It will be much easier compared to changing the color of the icon with some more logical checks.
Hiding works but there needs to be a way to unhide. Many times users likes to know what are all the flights configured in a VA.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nabeelio/phpvms/issues/1160#issuecomment-830009890, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARXKVMIPVMZARBMW2J7H4F3TLKDCDANCNFSM4326XHLA .
-- B. Fatih KOZ
Sent from mobile device / Mobil cihaz ile gonderildi.
I think #1580 closes more or less this one When the add bid doesn't work it displays an alert with the error message of the exception return by the api. We can maybe do a PR to add the red color on the button but if we just want the alert that's already done.
https://github.com/nabeelio/phpvms/pull/1580/files#diff-ceed2f8498467aabda8ef043837bc0ad365751696a5c27891b4747f5c05ee013R84-R86
@arthurpar06 What I was thinking for this was including info in the api response of if it's already been bid on or not. Then an alert box to show the user
@nabeelio When a bid already exists the api returns a 409 error with the message A bid already exists for this flight (BidExistsForFlight Exception) and then the code I mentionned above will display an alert saying "Error adding bid: a bid already exists for this flight"
Why not, as long as it is understandable and readable by anyone I am ok with it :) And I assume it will follow v7 settings and allow multiple bids for a flight according to va settings.
it only displays the error message returned by the api (if it returns one) so it supports multiple bids depending on the va settings and all other settings we have related to bids