phpvms icon indicating copy to clipboard operation
phpvms copied to clipboard

Profile updated event

Open russellwwest opened this issue 3 years ago • 10 comments

added a test to make sure the event is called.

on a side note, I noticed it keeps picking up my previous commits - not sure what I need to do to only show the commits related to the PR?

russellwwest avatar Apr 15 '21 16:04 russellwwest

@russellwwest you need to change to the dev branch, update dev and then create a new branch off of it

nabeelio avatar Apr 15 '21 16:04 nabeelio

That's probably the easiest way, the other way is to rebase off of dev.

nabeelio avatar Apr 15 '21 16:04 nabeelio

@russellwwest Can you clear up the StyleCI and build issues on this? Then I can merge it in, looks OK to me.

nabeelio avatar May 19 '21 22:05 nabeelio

Just fix the conflict too and it should be good to merge

nabeelio avatar Jun 01 '21 13:06 nabeelio

I'm confused by the style it's trying to make me do with the array / and white space.

russellwwest avatar Jun 01 '21 14:06 russellwwest

ahhh - nope - @nabeelio, really don't know what I need to do to pass the style ci check!?

russellwwest avatar Jun 01 '21 14:06 russellwwest

Do "download raw diff" and just apply that, that's what I do

nabeelio avatar Jun 01 '21 14:06 nabeelio

stylefix

Just remove the whitespace from that line, all will be ok then (we hope) If you are using VSCode, it has a feature to clean them automatically too, but deleting manually also works.

FatihKoz avatar Jun 05 '21 20:06 FatihKoz

Fixed File : EventServiceProvider.zip

FatihKoz avatar Jun 05 '21 20:06 FatihKoz

Sorry I haven't been able to do any Dev stuff due to work commitments, and don't think I'll be able to until next week

russellwwest avatar Jun 16 '21 22:06 russellwwest

@nabeelio, another one you can merge after applying the style fixes

ArthurHetem avatar Aug 23 '23 15:08 ArthurHetem

This won't push properly not sure why

nabeelio avatar Aug 23 '23 16:08 nabeelio