phpvms
phpvms copied to clipboard
Profile updated event
added a test to make sure the event is called.
on a side note, I noticed it keeps picking up my previous commits - not sure what I need to do to only show the commits related to the PR?
@russellwwest you need to change to the dev branch, update dev and then create a new branch off of it
That's probably the easiest way, the other way is to rebase off of dev.
@russellwwest Can you clear up the StyleCI and build issues on this? Then I can merge it in, looks OK to me.
Just fix the conflict too and it should be good to merge
I'm confused by the style it's trying to make me do with the array / and white space.
ahhh - nope - @nabeelio, really don't know what I need to do to pass the style ci check!?
Do "download raw diff" and just apply that, that's what I do
Just remove the whitespace from that line, all will be ok then (we hope) If you are using VSCode, it has a feature to clean them automatically too, but deleting manually also works.
Fixed File : EventServiceProvider.zip
Sorry I haven't been able to do any Dev stuff due to work commitments, and don't think I'll be able to until next week
@nabeelio, another one you can merge after applying the style fixes
This won't push properly not sure why