satyrographos icon indicating copy to clipboard operation
satyrographos copied to clipboard

Error: Jane Street style: Ignored expression must come with a type annotation in OCaml 4.08.1

Open na4zagin3 opened this issue 5 years ago • 5 comments

Apparently, automatically generated code (probably by ppx_sexp_conv) violates (unannotated-ignores rule](https://github.com/janestreet/ppx_js_style#-allow-unannotated-ignores)

- (cd _build/default && .ppx/b4175a47579235f9b841d5d1f64bf609/ppx.exe -o bin/commandLibrary.pp.ml --impl bin/commandLibrary.ml -corrected-suffix .ppx-corrected -diff-cmd - -dump-ast)
- File "_none_", line 1:
- Error: Jane Street style: Ignored expression must come with a type annotation
-          ppx bin/commandPin.pp.ml (exit 1)
- (cd _build/default && .ppx/b4175a47579235f9b841d5d1f64bf609/ppx.exe -o bin/commandPin.pp.ml --impl bin/commandPin.ml -corrected-suffix .ppx-corrected -diff-cmd - -dump-ast)
- File "_none_", line 1:
- Error: Jane Street style: Ignored expression must come with a type annotation
-          ppx bin/commandStatus.pp.ml (exit 1)
- (cd _build/default && .ppx/b4175a47579235f9b841d5d1f64bf609/ppx.exe -o bin/commandStatus.pp.ml --impl bin/commandStatus.ml -corrected-suffix .ppx-corrected -diff-cmd - -dump-ast)
- File "_none_", line 1:
- Error: Jane Street style: Ignored expression must come with a type annotation

na4zagin3 avatar Feb 03 '20 14:02 na4zagin3

Hi @na4zagin3, I got the same error message when I try to install Satyrographos to my environment (WSL2, Ubuntu 20.04, OCaml 4.08.1, opam 2.0.5). How can I avoid this error?

zeptometer avatar Oct 19 '20 04:10 zeptometer

FYI, here are log files from opam. satyrographos-3670-fe9c2d.zip

zeptometer avatar Oct 19 '20 04:10 zeptometer

Using OCaml 4.11.1 resolved the issue😄

zeptometer avatar Oct 19 '20 05:10 zeptometer

@zeptometer It's caused by a dependency problem where ancient versions of Satyrographos which don't compile with core v0.14. The versions hosted in the official OPAM repo have been fixed. I'll apply the same fix to the dependencies with https://github.com/na4zagin3/satyrographos-repo/pull/215 and https://github.com/gfngfn/satysfi-external-repo/pull/7.

na4zagin3 avatar Oct 19 '20 06:10 na4zagin3

Cool! Thank you for sharing the context.

zeptometer avatar Oct 19 '20 10:10 zeptometer