na2hiro

Results 41 comments of na2hiro

Probably it makes sense to create an independent class like `EditableShogi` for the editable version and allow switching between them via common serialization like SFEN.

要調査 - その他は伝統的に上手下手になっている? - ヘッダの"先手番" "後手番"を使う?

0ef265de04acb8f8a44343a7803d3bb18bb5b7d2 で二歩と行き所のない駒の判定を追加.打ち歩詰め,千日手,王手千日手もあると良い.

詰将棋おもちゃ箱のフェアリーコーナーの安南や対面ルールにおいて、fromとtoを指定可能なKIF形式を使用し、普通将棋では動けない箇所への移動や行きどころのない不成が発生する棋譜が存在。 https://twitter.com/Araiyayon/status/1700486630656835758 ひとつの案としては: * json-kifu-formatにおいては、普通では禁則となる棋譜を許すlooseモードを導入すべきか。禁則手にあたるmoveにillegalフラグを付与する。 * Kifu for JSにおいては、デフォルトではlooseモードで処理してillegalな場合に警告表示、設定で警告をオフにする(フェアリーとわかっている場合など)

#113 で概ね直したが、設定モーダルの大きさが小さくなってしまう問題が残っている ![Image](https://github.com/na2hiro/Kifu-for-JS/assets/736244/b51830f0-a4c6-40d3-8baf-b82fbbe0ee7b)

Thanks for checking. Yeah, I'll try to clarify what's going to be changed as much as possible. To move forward with extracting user settings, I resumed from the second commit...

Thanks for checking! > It looks like the test expectations need attempts data etc. so that they will pass, which I assume you're still working on. You're right, for the...

Updated: * 4th commit: Added logic to keep `attempts` correctly. Also updated test cases with failures to type out the next phrase. * Amended commits * 1st commit: Reverted module...

Thanks for the deeper look! > For the attempts, I think we want to push more detail than we currently are on this branch. Previously, "sigh", "silent" via SAOEU/HREPBT would...

Thanks for the detailed report. I think I fixed them. Could you test it on your environment? * typing a character in `userEvent.type()` can take more than 16ms and the...