ExcelCompare icon indicating copy to clipboard operation
ExcelCompare copied to clipboard

Hang on big .ods files.

Open magnetophon opened this issue 5 years ago • 4 comments

When I try two almost empty files I get a nice diff, but when I try a real-world example, it hangs. I can provide examples, if wanted.

magnetophon avatar Jul 29 '19 16:07 magnetophon

Yes please can you attach some examples?

On Mon, Jul 29, 2019, 09:44 Bart Brouns [email protected] wrote:

When I try two almost empty files I get a nice diff, but when I try a real-world example, it hangs. I can provide examples, if wanted.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/na-ka-na/ExcelCompare/issues/55?email_source=notifications&email_token=AACADBFWPBEUXEWAC3VMKTTQB4M75A5CNFSM4IHUIJK2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HCC7DRQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AACADBDKP5G5ANPVHWSCCC3QB4M75ANCNFSM4IHUIJKQ .

na-ka-na avatar Jul 29 '19 17:07 na-ka-na

Here you go: https://ufile.io/4dghlgak https://ufile.io/jhnccjrv

Github won't let me upload .ods files.

magnetophon avatar Jul 29 '19 17:07 magnetophon

+1 to this @na-ka-na

An incredibly helpful feature would also be to set a maximum diffs limit, so the process does not hang until it's finished writing to stdout.

I would actually use --max_diffs=1. My current use case is to simply check if there are any diffs at all based on the criteria, and for large files with a lot of diffs this is very slow. I would then run a full diff if interested in the output.

jrball3 avatar Jan 10 '20 22:01 jrball3

Same issue here. I had to convert my files to xlsx get it to work.

ClementFeltin avatar May 26 '20 09:05 ClementFeltin