n8n
n8n copied to clipboard
n8n-io
feat(TelegramTrigger Node): Replace allowedUpdates value for '*' option with full range of possible update types
Current value of allowedUpdates for '*' option is set to an empty array, which enables "all update types except chat_member, message_reaction, and message_reaction_count (default)". More details can be found in the Telegram Bot API documentation
It causes not receiving updates about new channel subscriber for example.
Review / Merge checklist
- [x] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use
(no-changelog)otherwise. (conventions) - [ ] Docs updated or follow-up ticket created.
- [ ] Tests included.
A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests.
Hey @seniorsolt,
Thanks for the PR, I have been thinking about this one and I believe that this has some potential to cause some issues if you are not expecting those 3 extra fields. This could be better as a light version with an option to use the default Telegram list if those 3 options are not needed, I guess there is a reason why they are not included in the first place.
Hello, @Joffcom,
Could you please clarify what kind of potential issues you are referring to? Are you talking about breaking old workflows after updating due to unexpected update types? Should I create a new request with a new option that includes a full range of possible update types instead of replacing '*' option?
Hey @seniorsolt,
If someone is not expecting the extra data in their current workflow and they are not handling this there is potential for errors.
The other side is it will also increase the execution count so users who pay per execution may suddenly see a jump.
What I would do is make a light mode version and make a 1.2 that has this change although it may be better as an extra option as it is a change from the API default that users may be expecting.