n8n icon indicating copy to clipboard operation
n8n copied to clipboard

fix potential GitHub Actions smells

Open ceddy4395 opened this issue 10 months ago • 2 comments

Summary

Describe what the PR does and how to test. Photos and videos are recommended.

Hey! 🙂 I want to contribute the following changes to your workflow:

  • Avoid executing scheduled workflows on forks
  • Avoid uploading artifacts on forks
  • Stop running workflows when there is a newer commit in branch
  • Stop running workflows when there is a newer commit in PR

(These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more)

Related tickets and issues

Include links to Linear ticket or Github issue or Community forum post. Important in order to close automatically and provide context to reviewers.

Review / Merge checklist

  • [ ] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • [ ] Docs updated or follow-up ticket created.
  • [ ] Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests.

ceddy4395 avatar Apr 29 '24 09:04 ceddy4395

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 29 '24 09:04 CLAassistant

@netroy These look like good sanity checks. Care to review as well?

alexgrozav avatar Jun 20 '24 10:06 alexgrozav