n8n icon indicating copy to clipboard operation
n8n copied to clipboard

feat(Wise Node): Add XML as supported format in getStatement operation

Open webkp opened this issue 10 months ago • 2 comments

Summary

Describe what the PR does and how to test. Photos and videos are recommended.

Wise added XML (CAMT.053) as supported format to generate statements through their API. Related docs from Wise: https://docs.wise.com/api-docs/api-reference/balance-statement#get

This PR simply adds XML as supported format as option in the UI (as binary type, same as with already present options CSV and PDF) as well as to the backend code where the chosen format is appended to the request url.

wise-node-xml-format

n8n docs are not affected since supported formats are not mentioned: https://docs.n8n.io/integrations/builtin/app-nodes/n8n-nodes-base.wise/

Related tickets and issues

Include links to Linear ticket or Github issue or Community forum post. Important in order to close automatically and provide context to reviewers.

None available.

Review / Merge checklist

  • [x] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • [ ] Docs updated or follow-up ticket created.
  • [ ] Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests.

webkp avatar Apr 22 '24 22:04 webkp

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 22 '24 22:04 CLAassistant

I have added to my list of PRs to review on Monday morning.

Joffcom avatar Apr 25 '24 15:04 Joffcom

Got released with [email protected]

janober avatar May 02 '24 12:05 janober