n8n
n8n copied to clipboard
n8n-io
refactor(editor): Migrate header WorkflowDetails to composition api (no-changelog)
Summary
Migrates WorkflowDetails to Composition API. Rewrites all the getters to use the workflow directly from the props.
Related tickets and issues
https://linear.app/n8n/issue/N8N-7345/migrate-workflowdetails-to-composition-api
Review / Merge checklist
- [x] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use
(no-changelog)otherwise. (conventions) - [x] Docs updated or follow-up ticket created.
- [x] Tests included.
A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests.
Probably unrelated to this PR, but text and X icon in tags seems to be not aligned
:warning: Some Cypress E2E specs are failing, please fix them before merging
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
1 flaky test on run #4797 ↗︎
 0 |
 358 |
 12 |
 0 |
 1 |
Details:
| 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/* | |||
| Project: n8n | Commit: b93e7ac230 |
||
| Status: Passed | Duration: 04:33 💡 | ||
| Started: Apr 26, 2024 3:08 PM | Ended: Apr 26, 2024 3:13 PM | ||
cypress/e2e/24-ndv-paired-item.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9186 ↗︎
![cypress[bot] avatar](https://avatars.githubusercontent.com/in/9078?v=4 "Published by a pub.dev verified publisher"){kind=small}
:warning: Some Cypress E2E specs are failing, please fix them before merging
